Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java

Issue 2666833002: Create entry to PWSharing through ShareHelper (Closed)
Patch Set: Fixing nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java
index 243cf45b931d1ad8286fc20631dea9f80c3f3697..64dd1bbd7c94384e7934adae6092432c0b98b049 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java
@@ -4,181 +4,31 @@
package org.chromium.chrome.browser.printing;
-import android.app.Activity;
-import android.content.ComponentName;
-import android.content.Intent;
-import android.content.pm.PackageManager;
-import android.os.AsyncTask;
-import android.os.Bundle;
-import android.os.StrictMode;
-import android.support.v7.app.AppCompatActivity;
-
-import org.chromium.base.ActivityState;
-import org.chromium.base.ApplicationStatus;
-import org.chromium.base.ApplicationStatus.ActivityStateListener;
-import org.chromium.base.Log;
-import org.chromium.base.ThreadUtils;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.share.ShareHelper;
-import org.chromium.chrome.browser.util.IntentUtils;
-
-import java.lang.ref.WeakReference;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
-import java.util.concurrent.ExecutionException;
+import org.chromium.chrome.browser.preferences.PrefServiceBridge;
+import org.chromium.chrome.browser.share.ShareActivity;
+import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.printing.PrintingController;
+import org.chromium.printing.PrintingControllerImpl;
/**
* A simple activity that allows Chrome to expose print as an option in the share menu.
*/
-public class PrintShareActivity extends AppCompatActivity {
-
- private static final String TAG = "cr_printing";
-
- private static Set<Activity> sPendingShareActivities =
- Collections.synchronizedSet(new HashSet<Activity>());
- private static ActivityStateListener sStateListener;
- private static AsyncTask<Void, Void, Void> sStateChangeTask;
-
- /**
- * Enable the print sharing option.
- *
- * @param activity The activity that will be triggering the share action. The activitiy's
- * state will be tracked to disable the print option when the share operation
- * has been completed.
- * @param callback The callback to be triggered after the print option has been enabled. This
- * may or may not be synchronous depending on whether this will require
- * interacting with the Android framework.
- */
- public static void enablePrintShareOption(final Activity activity, final Runnable callback) {
- ThreadUtils.assertOnUiThread();
-
- if (sStateListener == null) {
- sStateListener = new ActivityStateListener() {
- @Override
- public void onActivityStateChange(Activity activity, int newState) {
- if (newState == ActivityState.PAUSED) return;
- unregisterActivity(activity);
- }
- };
- }
- ApplicationStatus.registerStateListenerForAllActivities(sStateListener);
- boolean wasEmpty = sPendingShareActivities.isEmpty();
- sPendingShareActivities.add(activity);
-
- waitForPendingStateChangeTask();
- if (wasEmpty) {
- sStateChangeTask = new AsyncTask<Void, Void, Void>() {
- @Override
- protected Void doInBackground(Void... params) {
- if (sPendingShareActivities.isEmpty()) return null;
-
- activity.getPackageManager().setComponentEnabledSetting(
- new ComponentName(activity, PrintShareActivity.class),
- PackageManager.COMPONENT_ENABLED_STATE_ENABLED,
- PackageManager.DONT_KILL_APP);
- return null;
- }
-
- @Override
- protected void onPostExecute(Void result) {
- if (sStateChangeTask == this) {
- sStateChangeTask = null;
- } else {
- waitForPendingStateChangeTask();
- }
- callback.run();
- }
- }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
- } else {
- callback.run();
- }
- }
-
- private static void unregisterActivity(final Activity activity) {
- ThreadUtils.assertOnUiThread();
-
- sPendingShareActivities.remove(activity);
- if (!sPendingShareActivities.isEmpty()) return;
- ApplicationStatus.unregisterActivityStateListener(sStateListener);
-
- waitForPendingStateChangeTask();
- sStateChangeTask = new AsyncTask<Void, Void, Void>() {
- @Override
- protected Void doInBackground(Void... params) {
- if (!sPendingShareActivities.isEmpty()) return null;
-
- activity.getPackageManager().setComponentEnabledSetting(
- new ComponentName(activity, PrintShareActivity.class),
- PackageManager.COMPONENT_ENABLED_STATE_DISABLED,
- PackageManager.DONT_KILL_APP);
- return null;
- }
-
- @Override
- protected void onPostExecute(Void result) {
- if (sStateChangeTask == this) sStateChangeTask = null;
- }
- }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
- }
-
- /**
- * Waits for any pending state change operations to be completed.
- *
- * This will avoid timing issues described here: crbug.com/649453.
- */
- private static void waitForPendingStateChangeTask() {
- ThreadUtils.assertOnUiThread();
-
- if (sStateChangeTask == null) return;
- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
- try {
- sStateChangeTask.get();
- sStateChangeTask = null;
- } catch (InterruptedException | ExecutionException e) {
- Log.e(TAG, "Print state change task did not complete as expected");
- } finally {
- StrictMode.setThreadPolicy(oldPolicy);
- }
- }
+public class PrintShareActivity extends ShareActivity {
@Override
- protected void onCreate(Bundle savedInstanceState) {
- super.onCreate(savedInstanceState);
-
- try {
- Intent intent = getIntent();
- if (intent == null) return;
- if (!Intent.ACTION_SEND.equals(intent.getAction())) return;
- if (!IntentUtils.safeHasExtra(getIntent(), ShareHelper.EXTRA_TASK_ID)) return;
- handlePrintAction();
- } finally {
- finish();
- }
+ protected void handleShareAction() {
+ getTriggeringActivity().onMenuOrKeyboardAction(R.id.print_id, true);
}
- private void handlePrintAction() {
- int triggeringTaskId =
- IntentUtils.safeGetIntExtra(getIntent(), ShareHelper.EXTRA_TASK_ID, 0);
- List<WeakReference<Activity>> activities = ApplicationStatus.getRunningActivities();
- ChromeActivity triggeringActivity = null;
- for (int i = 0; i < activities.size(); i++) {
- Activity activity = activities.get(i).get();
- if (activity == null) continue;
-
- // Since the share intent is triggered without NEW_TASK or NEW_DOCUMENT, the task ID
- // of this activity will match that of the triggering activity.
- if (activity.getTaskId() == triggeringTaskId
- && activity instanceof ChromeActivity) {
- triggeringActivity = (ChromeActivity) activity;
- break;
- }
+ @Override
+ public boolean featureIsEnabled(Tab currentTab) {
+ PrintingController printingController = PrintingControllerImpl.getInstance();
+ if (printingController != null && !currentTab.isNativePage()
+ && !printingController.isBusy()
+ && PrefServiceBridge.getInstance().isPrintingEnabled()) {
+ return true;
}
- if (triggeringActivity == null) return;
- unregisterActivity(triggeringActivity);
- triggeringActivity.onMenuOrKeyboardAction(R.id.print_id, true);
+ return false;
}
-
}

Powered by Google App Engine
This is Rietveld 408576698