Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Remove extraneous brace Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
7 7
8 #include "ui/views/layout/grid_layout.h" 8 #include "ui/views/layout/grid_layout.h"
9 9
10 class LayoutDelegate { 10 class LayoutDelegate {
11 public: 11 public:
12 enum class Metric { 12 enum class Metric {
13 // Extra padding added on all sides of a button's content. This is only 13 // Extra padding added on all sides of a button's content. This is only
14 // used for certain button types. 14 // used for certain button types.
15 // TODO(pkasting): This should probably be touch-specific and needs to be 15 // TODO(pkasting): This should probably be touch-specific and needs to be
16 // considered more holistically. 16 // considered more holistically.
17 BUTTON_PADDING, 17 BUTTON_PADDING,
18 // Horizontal or vertical margin between the edge of a dialog and a 18 // Horizontal or vertical margin between the edge of a dialog and a
19 // contained button. 19 // contained button.
20 DIALOG_BUTTON_MARGIN, 20 DIALOG_BUTTON_MARGIN,
21 // Horizontal or vertical margin between the edge of a dialog and the close
22 // button in the upper trailing corner.
23 DIALOG_CLOSE_BUTTON_MARGIN,
21 // Horizontal or vertical margin between the edge of a panel and the 24 // Horizontal or vertical margin between the edge of a panel and the
22 // contained content. 25 // contained content.
23 PANEL_CONTENT_MARGIN, 26 PANEL_CONTENT_MARGIN,
24 // Horizontal spacing between buttons that are logically related, e.g. 27 // Horizontal spacing between buttons that are logically related, e.g.
25 // for a button set. 28 // for a button set.
26 RELATED_BUTTON_HORIZONTAL_SPACING, 29 RELATED_BUTTON_HORIZONTAL_SPACING,
27 // Horizontal spacing between other controls that are logically related. 30 // Horizontal spacing between other controls that are logically related.
28 RELATED_CONTROL_HORIZONTAL_SPACING, 31 RELATED_CONTROL_HORIZONTAL_SPACING,
29 // Vertical spacing between controls that are logically related. 32 // Vertical spacing between controls that are logically related.
30 RELATED_CONTROL_VERTICAL_SPACING, 33 RELATED_CONTROL_VERTICAL_SPACING,
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 80
78 // Returns the preferred width in DIPs for a dialog of the specified |width|. 81 // Returns the preferred width in DIPs for a dialog of the specified |width|.
79 // May return 0 if the dialog has no preferred width. 82 // May return 0 if the dialog has no preferred width.
80 virtual int GetDialogPreferredWidth(DialogWidth width) const; 83 virtual int GetDialogPreferredWidth(DialogWidth width) const;
81 84
82 private: 85 private:
83 DISALLOW_COPY_AND_ASSIGN(LayoutDelegate); 86 DISALLOW_COPY_AND_ASSIGN(LayoutDelegate);
84 }; 87 };
85 88
86 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_ 89 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698