Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2666803002: Add SuperPropertyGet. (Closed)

Created:
3 years, 10 months ago by Emily Fortuna
Modified:
3 years, 10 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add SuperPropertyGet. BUG=https://github.com/dart-lang/sdk/issues/27394 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/6baace1a2f43ef7d4353204a5598ddd602c62944

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +24 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Emily Fortuna
SuperPropertySet is on the way!
3 years, 10 months ago (2017-01-31 00:14:09 UTC) #3
Emily Fortuna
https://codereview.chromium.org/2666803002/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2666803002/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode236 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:236: // TODO(efortuna): Common interface? these are clearly screaming out ...
3 years, 10 months ago (2017-01-31 00:17:16 UTC) #4
sra1
lgtm
3 years, 10 months ago (2017-01-31 21:25:48 UTC) #5
Emily Fortuna
3 years, 10 months ago (2017-01-31 21:53:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
6baace1a2f43ef7d4353204a5598ddd602c62944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698