Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 266673014: Added pinch viewport offset to page state. (Closed)

Created:
6 years, 7 months ago by bokan
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Added pinch viewport offset to page state. Added field allows Blink to properly restore pinch-zoomed page when using new "virtual viewport" mode of pinch. Dependent Blink patch: https://codereview.chromium.org/263853008 BUG=364112 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269724

Patch Set 1 #

Patch Set 2 : Added values for backward compatibility #

Patch Set 3 : Fixed unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M content/common/page_state_serialization.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/page_state_serialization.cc View 1 3 chunks +13 lines, -1 line 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/page_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/history_serialization.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aelias_OOO_until_Jul13
Looks mostly OK. The only problem is we should have a plan for making the ...
6 years, 7 months ago (2014-05-02 07:32:50 UTC) #1
bokan
Alexandre, PTAL. I've added (-1, -1) as a signal to distribute the scroll offset. I've ...
6 years, 7 months ago (2014-05-06 20:12:55 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-05-07 08:10:19 UTC) #3
bokan
+darin@ for OWNER
6 years, 7 months ago (2014-05-07 12:52:24 UTC) #4
bokan
On 2014/05/07 12:52:24, bokan wrote: > +darin@ for OWNER Hi Darin, could you please take ...
6 years, 7 months ago (2014-05-08 19:42:05 UTC) #5
Avi (use Gerrit)
lgtm Looks reasonable.
6 years, 7 months ago (2014-05-09 15:06:39 UTC) #6
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 7 months ago (2014-05-11 16:28:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/266673014/20001
6 years, 7 months ago (2014-05-11 16:28:42 UTC) #8
bokan
The CQ bit was unchecked by bokan@chromium.org
6 years, 7 months ago (2014-05-11 17:40:55 UTC) #9
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 7 months ago (2014-05-11 18:00:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/266673014/40001
6 years, 7 months ago (2014-05-11 18:00:42 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 23:23:40 UTC) #12
Message was sent while issue was closed.
Change committed as 269724

Powered by Google App Engine
This is Rietveld 408576698