Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 26667005: Android: disable 2d canvas AA in a different place. (Closed)

Created:
7 years, 2 months ago by Torne
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: disable 2d canvas AA in a different place. Instead of disabling 2d canvas antialiasing for Android in content_startup_flags (which can't easily be overridden by content embedders), disable it in chrome_startup_flags (which disables it for Chrome and Chromium TestShell on Android, which is what was desired) and also in shell_main_delegate (which disables it for ContentShell on Android for the purposes of consistency in manual/automated testing). Other content embedders (such as android_webview) are now free to control this flag themselves. BUG=213238 R=pfeldman@chromium.org, senorblanco@chromium.org, yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/android/chrome_startup_flags.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
Hi Stephen, Grace, We want to move this flag to be enabled for Chrome and ...
7 years, 2 months ago (2013-10-10 10:51:56 UTC) #1
Torne
+tedchoc for OWNERS in chrome/browser/android and content/browser/android +pfeldman for OWNERS in content/shell/app
7 years, 2 months ago (2013-10-10 10:54:16 UTC) #2
pfeldman
shell rs lgtm
7 years, 2 months ago (2013-10-10 12:14:46 UTC) #3
Stephen White
LGTM, although I'm not an expert in this code
7 years, 2 months ago (2013-10-10 12:31:36 UTC) #4
Yaron
lgtm
7 years, 2 months ago (2013-10-10 13:09:10 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-10 13:09:35 UTC) #6
Torne
7 years, 2 months ago (2013-10-10 14:20:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r227928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698