detect flutter and use default analysis options for flutter

detect flutter and use default analysis options for flutter

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/23f92339a435c488572b173ba68ff63525064bd8

[danrubel, 2017-01-30 19:49:55]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-01-30 20:40:47]

lgtm

https://codereview.chromium.org/2666693002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2666693002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:745: // Alternately, we could check
the pubspec for "sdk: flutter"
Personally, I think checking the package map is better. We don't currently have
support for reading the pubspec.yaml file, while we do have a package map.

[danrubel, 2017-01-30 20:47:11]

https://codereview.chromium.org/2666693002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2666693002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:745: // Alternately, we could check
the pubspec for "sdk: flutter"
On 2017/01/30 20:40:47, Brian Wilkerson wrote:
> Personally, I think checking the package map is better. We don't currently
have
> support for reading the pubspec.yaml file, while we do have a package map.

Agreed.

[danrubel, 2017-01-30 20:48:11]

Description was changed from

==========
detect flutter and use default analysis options for flutter
==========

to

==========
detect flutter and use default analysis options for flutter

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/23f92339a435c488572b173ba68ff63525064bd8
==========

[danrubel, 2017-01-30 20:48:12]

Committed patchset #1 (id:1) manually as
23f92339a435c488572b173ba68ff63525064bd8 (presubmit successful).