Record field-trial information in stability file for crash analysis.

chrome/browser/chrome_browser_field_trials_desktop.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_field_trials_desktop.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
@@ skipping 94 matching lines @@
 
   module.file = "chrome.dll";
   module.debug_file = "chrome.dll.pdb";
 
   global_tracker->RecordModuleInfo(module);
 }
 
 void SetupStabilityDebugging() {
   if (!base::FeatureList::IsEnabled(
           browser_watcher::kStabilityDebuggingFeature)) {
+    base::debug::GlobalActivityTracker::DisableFieldTrialRecording();

[Alexei Svitkine (slow), 2017/02/07 16:14:06]

I notice SetupStabilityDebugging() is only called on Windows.

So on other platforms we'll never hit this Disable call.

What will happen then - since the field_trial.cc code still runs on all the
platforms?

[bcwhite, 2017/02/07 17:39:31]

Good catch.  Added call to disable on non-Win platforms.

     return;
   }
 
   // TODO(bcwhite): Adjust these numbers once there is real data to show
   // just how much of an arena is necessary.
   const size_t kMemorySize = 1 << 20;  // 1 MiB
   const int kStackDepth = 4;
   const uint64_t kAllocatorId = 0;
 
   // Ensure the stability directory exists and determine the stability file's
@@ skipping 29 matching lines @@
     CHECK(::GetModuleFileName(nullptr, exe_file, arraysize(exe_file)));
 
     base::string16 product_name;
     base::string16 version_number;
     base::string16 channel_name;
     base::string16 special_build;
     install_static::GetExecutableVersionDetails(exe_file, &product_name,
                                                 &version_number, &special_build,
                                                 &channel_name);
 
-    base::debug::ActivityUserData& global_data = global_tracker->user_data();
+    base::debug::ActivityUserData& global_data = global_tracker->global_data();
     global_data.SetString(browser_watcher::kStabilityProduct, product_name);
     global_data.SetString(browser_watcher::kStabilityVersion, version_number);
     global_data.SetString(browser_watcher::kStabilityChannel, channel_name);
     global_data.SetString(browser_watcher::kStabilitySpecialBuild,
                           special_build);
 #if defined(ARCH_CPU_X86)
     global_data.SetString(browser_watcher::kStabilityPlatform, "Win32");
 #elif defined(ARCH_CPU_X86_64)
     global_data.SetString(browser_watcher::kStabilityPlatform, "Win64");
 #endif
@@ skipping 15 matching lines @@
 #endif  // defined(OS_WIN)
   // Activate the experiment as early as possible to increase its visibility
   // (e.g. the likelihood of its presence in the serialized system profile).
   // This also needs to happen before the browser rendez-vous attempt
   // (NotifyOtherProcessOrCreate) in PreMainMessageLoopRun so the corresponding
   // metrics are tagged.
   base::FeatureList::IsEnabled(features::kDesktopFastShutdown);
 }
 
 }  // namespace chrome