Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/reading_list/url_downloader.h

Issue 2666643002: Remove usage of DomDistillerService in ReadingListDownloadService. (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/url_downloader.h
diff --git a/ios/chrome/browser/reading_list/url_downloader.h b/ios/chrome/browser/reading_list/url_downloader.h
index f9c26a38458e826f5fde29d7fde5854f4dde8c15..862df2afd809926d0384ee3dd9bc82aab90ddc69 100644
--- a/ios/chrome/browser/reading_list/url_downloader.h
+++ b/ios/chrome/browser/reading_list/url_downloader.h
@@ -18,10 +18,6 @@ namespace base {
class FilePath;
}
-namespace dom_distiller {
-class DomDistillerService;
-}
-
namespace net {
class URLFetcher;
class URLRequestContextGetter;
@@ -82,7 +78,7 @@ class URLDownloader : public net::URLFetcherDelegate,
// and a boolean indicating success. For downloads, if distillation was
// successful, it will also include the distilled url and extracted title.
URLDownloader(
- dom_distiller::DomDistillerService* distiller_service,
+ dom_distiller::DistillerFactory* distiller_factory,
reading_list::ReadingListDistillerPageFactory* distiller_page_factory,
PrefService* prefs,
base::FilePath chrome_profile_path,
@@ -177,11 +173,12 @@ class URLDownloader : public net::URLFetcherDelegate,
// Saves the file downloaded by |fetcher_|. Creates the directory if needed.
SuccessState SavePDFFile(const base::FilePath& temporary_path);
- dom_distiller::DomDistillerService* distiller_service_;
reading_list::ReadingListDistillerPageFactory* distiller_page_factory_;
+ dom_distiller::DistillerFactory* distiller_factory_;
PrefService* pref_service_;
const DownloadCompletion download_completion_;
const SuccessCompletion delete_completion_;
+
std::deque<Task> tasks_;
bool working_;
base::FilePath base_directory_;

Powered by Google App Engine
This is Rietveld 408576698