Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/reading_list/reading_list_download_service.cc

Issue 2666643002: Remove usage of DomDistillerService in ReadingListDownloadService. (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_download_service.cc
diff --git a/ios/chrome/browser/reading_list/reading_list_download_service.cc b/ios/chrome/browser/reading_list/reading_list_download_service.cc
index 32e091452421713361df914e78a60d2338090fc5..5c861446ead4cb78c7118993e8b806a19924d957 100644
--- a/ios/chrome/browser/reading_list/reading_list_download_service.cc
+++ b/ios/chrome/browser/reading_list/reading_list_download_service.cc
@@ -42,21 +42,22 @@ const int kNumberOfFailsBeforeStop = 7;
ReadingListDownloadService::ReadingListDownloadService(
ReadingListModel* reading_list_model,
- dom_distiller::DomDistillerService* distiller_service,
PrefService* prefs,
base::FilePath chrome_profile_path,
net::URLRequestContextGetter* url_request_context_getter,
+ std::unique_ptr<dom_distiller::DistillerFactory> distiller_factory,
std::unique_ptr<reading_list::ReadingListDistillerPageFactory>
distiller_page_factory)
: reading_list_model_(reading_list_model),
chrome_profile_path_(chrome_profile_path),
had_connection_(!net::NetworkChangeNotifier::IsOffline()),
distiller_page_factory_(std::move(distiller_page_factory)),
+ distiller_factory_(std::move(distiller_factory)),
weak_ptr_factory_(this) {
DCHECK(reading_list_model);
url_downloader_ = base::MakeUnique<URLDownloader>(
- distiller_service, distiller_page_factory_.get(), prefs,
+ distiller_factory_.get(), distiller_page_factory_.get(), prefs,
chrome_profile_path, url_request_context_getter,
base::Bind(&ReadingListDownloadService::OnDownloadEnd,
base::Unretained(this)),

Powered by Google App Engine
This is Rietveld 408576698