Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2666593002: Some test cleanup (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Some test cleanup These tests occasionally time out on travis. uri_test as well, but there are two tests with that name, so I added code to disambiguate in the logs. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/c88a17ff55fae3111f39487ff443997fda7c8a86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 10 months ago (2017-01-30 16:26:31 UTC) #3
Jennifer Messerly
lgtm
3 years, 10 months ago (2017-01-31 01:14:21 UTC) #4
vsm
3 years, 10 months ago (2017-01-31 18:23:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c88a17ff55fae3111f39487ff443997fda7c8a86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698