Add KernelWorldBuilder and KElement model.

Add KernelWorldBuilder and KElement model.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/1672873f451b247d480811517d6acbc71c97cd8a

[Johnni Winther, 2017-01-30 14:53:15]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-30 20:31:36]

lgtm

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/elements.dart (right):

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/elements.dart:13: final String name;
do you expect we'll eventually have a field here directly pointing at the
ir.Library node? Or will that be stored as a separate map?

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/world_builder.dart (right):

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:27: KEnv _env;
Asger has a change that will be adding canonical names to the kernel IR, so I
expect the fast lookup will be supported directly there. Maybe we don't need
these Env objects when that lands? WDYT?

Here is Asger's CL: https://codereview.chromium.org/2665723002/

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:81: } else if (node.parent is
ir.FunctionNode) {
nit: since there is a return above, remove else here?

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:88: } else if (func.parent is
ir.Procedure) {
same here

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:189: // no longer use resolution
types.
why is it not allowed today? aren't resolution types subtypes of DartType as
well?

[Johnni Winther, 2017-01-31 09:27:25]

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/elements.dart (right):

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/elements.dart:13: final String name;
On 2017/01/30 20:31:36, Siggi Cherem (dart-lang) wrote:
> do you expect we'll eventually have a field here directly pointing at the
> ir.Library node? Or will that be stored as a separate map?

I want to avoid it. I would like to be able to flush the IR from memory when we
no longer need it.

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/world_builder.dart (right):

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:27: KEnv _env;
On 2017/01/30 20:31:36, Siggi Cherem (dart-lang) wrote:
> Asger has a change that will be adding canonical names to the kernel IR, so I
> expect the fast lookup will be supported directly there. Maybe we don't need
> these Env objects when that lands? WDYT?
> 
> Here is Asger's CL: https://codereview.chromium.org/2665723002/

We need more. The CL provides `lookupLibrary(Uri)` functionality but not
lookupLibraryMember, lookupClass, lookupClassMember, lookupConstructor...

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:81: } else if (node.parent is
ir.FunctionNode) {
On 2017/01/30 20:31:36, Siggi Cherem (dart-lang) wrote:
> nit: since there is a return above, remove else here?

Done.

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:88: } else if (func.parent is
ir.Procedure) {
On 2017/01/30 20:31:36, Siggi Cherem (dart-lang) wrote:
> same here

Done.

https://codereview.chromium.org/2666553002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:189: // no longer use resolution
types.
On 2017/01/30 20:31:36, Siggi Cherem (dart-lang) wrote:
> why is it not allowed today? aren't resolution types subtypes of DartType as
> well?

[ResolutionDartType] is a subtype of [DartType] but if we pass a
`List<DartType>` to someone expecting a `List<ResolutionDartType>` we get a type
error even when the content is actually [ResolutionDartType]s. To avoid this
'spurious' error I avoid giving collections their type arguments. We have
already had similar issues with `Set<ClassEntity>` vs `Set<ClassElement>`
elsewhere in the refactored code. When we are done with the refactor the type
arguments should be reinserted.

[Johnni Winther, 2017-01-31 09:33:42]

Description was changed from

==========
Add KernelWorldBuilder and KElement model.
==========

to

==========
Add KernelWorldBuilder and KElement model.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1672873f451b247d480811517d6acbc71c97cd8a
==========

[Johnni Winther, 2017-01-31 09:33:43]

Committed patchset #3 (id:40001) manually as
1672873f451b247d480811517d6acbc71c97cd8a (presubmit successful).