Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2666523002: Allow permission bubbles to participate in key event dispatch as if they were a Browser. (Closed)
Patch Set: comments, fix permission->type missed in a refactor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_request_manager_test_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_manager.h
diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h
index 0348ab1e21903f245f613c3ff0565f8ce7cd2fa6..9bb770fbbcd14bf10f88ef518fb456edb4b94657 100644
--- a/chrome/browser/permissions/permission_request_manager.h
+++ b/chrome/browser/permissions/permission_request_manager.h
@@ -21,6 +21,10 @@ namespace safe_browsing {
class PermissionReporterBrowserTest;
}
+namespace test {
+class PermissionRequestManagerTestApi;
+}
+
// Provides access to permissions bubbles. Allows clients to add a request
// callback interface to the existing permission bubble configuration.
// Depending on the situation and policy, that may add new UI to an existing
@@ -107,7 +111,10 @@ class PermissionRequestManager
}
private:
- // TODO(felt): Update testing so that it doesn't involve a lot of friends.
+ friend class test::PermissionRequestManagerTestApi;
+
+ // TODO(felt): Update testing to use the TestApi so that it doesn't involve a
+ // lot of friends.
friend class GeolocationBrowserTest;
friend class GeolocationPermissionContextTests;
friend class MockPermissionPrompt;
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_request_manager_test_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698