Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: headless/BUILD.gn

Issue 2666503002: Make headless_shell target compile for Windows (Closed)
Patch Set: revert .gn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/app/headless_shell.cc » ('j') | headless/app/headless_shell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/BUILD.gn
diff --git a/headless/BUILD.gn b/headless/BUILD.gn
index 7f155ee2e080e1c520781bb5822be8ac047a6ac9..86e08349ab916e9dd62b4784f8e4f63e0c2f7d89 100644
--- a/headless/BUILD.gn
+++ b/headless/BUILD.gn
@@ -368,6 +368,8 @@ static_library("headless_shell_lib") {
deps = [
"//headless:headless_lib",
]
+
+ configs += [ ":headless_implementation" ]
}
executable("headless_shell") {
@@ -378,4 +380,14 @@ executable("headless_shell") {
deps = [
"//headless:headless_shell_lib",
]
+
+ configs += [ ":headless_implementation" ]
+
+ if (is_win) {
Sami 2017/02/09 17:51:40 Should these go into the headless_lib target since
dvallet 2017/02/10 05:29:49 Done
+ deps += [
+ "//build/win:default_exe_manifest",
+ "//content:sandbox_helper_win",
+ "//sandbox",
+ ]
+ }
}
« no previous file with comments | « no previous file | headless/app/headless_shell.cc » ('j') | headless/app/headless_shell.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698