Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issue 266643005: Revert 267354 "Refactor views app list services to allow more co..." (Closed)

Created:
6 years, 7 months ago by jsbell
Modified:
6 years, 7 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 267354 "Refactor views app list services to allow more co..." Causing Mac build failures > Refactor views app list services to allow more code sharing > > To run the toolkit-views app launcher on Mac, it needs a new app list > service + supporting classes. It's going to look a lot like the Linux > one. This CL starts by sharing what can be shared between Windows and > Linux, in preparation for using it on Mac as well. > > It does this principally by: > - Moving `app_list_shower` to `app_list_shower_views`, making it views-specific; > - Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from; > - Rearranging the delegation to eliminate some boilerplate. > > Other changes: > - Removed AppList container abstract interface (now just access AppListView); > - Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile()); > - Moved AppListControllerDelegateLinux to AppListControllerDelegateViews; > - Most of AppListServiceLinux moves to AppListServiceViews; > - Added AppListShowerDelegate and AppListShower given virtual method > hooks to assist testability (previously AppListShower was given a NULL > service/delegate in tests); > - Positioning logic in AppListWin/AppListLinux made static/stateless; > - Removes the `on_should_dismiss_` closure (now just dismiss via the service; > - Big trim of AppListServiceWin and AppListServiceLinux - now these are > just platform-specific stuff. > > BUG=365977 > TEST=Just refactoring, nothing should change > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184 > > Review URL: https://codereview.chromium.org/225053004 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -715 lines) Patch
A + trunk/src/chrome/browser/ui/app_list/app_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_controller_delegate_views.h View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_controller_delegate_views.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A + trunk/src/chrome/browser/ui/app_list/app_list_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_service_views.h View 1 chunk +0 lines, -56 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_service_views.cc View 1 chunk +0 lines, -71 lines 0 comments Download
A + trunk/src/chrome/browser/ui/app_list/app_list_shower.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/app_list/app_list_shower.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_shower_delegate.h View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_shower_views.h View 1 chunk +0 lines, -75 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_shower_views.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_shower_views_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
A + trunk/src/chrome/browser/ui/app_list/test/app_list_shower_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/app_list/linux/app_list_controller_delegate_linux.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/app_list/linux/app_list_controller_delegate_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/linux/app_list_linux.h View 3 chunks +33 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 3 chunks +62 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/linux/app_list_linux_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/linux/app_list_service_linux.h View 1 chunk +21 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 3 chunks +85 lines, -24 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/activation_tracker_win.h View 2 chunks +12 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/activation_tracker_win.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.h View 1 chunk +19 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc View 2 chunks +21 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_service_win.h View 3 chunks +21 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 7 chunks +95 lines, -25 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_win.h View 2 chunks +29 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/win/app_list_win.cc View 3 chunks +45 lines, -7 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 3 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jsbell
6 years, 7 months ago (2014-05-01 00:08:26 UTC) #1
jsbell
Committed patchset #1 manually as r267383 (tree was closed).
6 years, 7 months ago (2014-05-01 00:08:52 UTC) #2
jsbell
Sample failure: http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/7304/steps/compile/logs/stdio
6 years, 7 months ago (2014-05-01 00:08:55 UTC) #3
tapted
6 years, 7 months ago (2014-05-01 00:12:38 UTC) #4
Message was sent while issue was closed.
lgtm - thanks for taking care of it

Powered by Google App Engine
This is Rietveld 408576698