linux_aura: Add a flag for experimenting with ARGB windows.

linux_aura: Add a flag for experimenting with ARGB windows.

We have many windows that assume a transparent background, such as drag
windows. Using an ARGB visual means that drag representations can mostly
be transparent, with nicer rounded corners, and windows which draw their
own shadows.

However, we can't turn this on by default as is. While this works with
--disable_gpu and theoretically on the open source drivers, it won't
work with NVidia's drivers. Put this behind a flag so we can do further
experimenting.

BUG=347333, 369209
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267718

[piman, 2014-05-01 19:17:27]

https://codereview.chromium.org/266643003/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/266643003/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1290: // NVidia's
binaries currently.)
nit: file a bug so that we can track the remaining work?

[piman, 2014-05-01 19:17:44]

lgtm

[Elliot Glaysher, 2014-05-01 20:23:47]

sky: owners stamp

[sky, 2014-05-01 22:30:20]

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches.h
File ui/views/views_switches.h (right):

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches....
ui/views/views_switches.h:18: #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
Should this be USE_X11?

[sky, 2014-05-01 22:30:51]

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches.h
File ui/views/views_switches.h (right):

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches....
ui/views/views_switches.h:18: #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
On 2014/05/01 22:30:20, sky wrote:
> Should this be USE_X11?

By this I mean:
if defined(USE_X11) && !defined(OS_CHROMEOS)?

[Elliot Glaysher, 2014-05-01 22:42:22]

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches.h
File ui/views/views_switches.h (right):

https://codereview.chromium.org/266643003/diff/20001/ui/views/views_switches....
ui/views/views_switches.h:18: #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
On 2014/05/01 22:30:52, sky wrote:
> On 2014/05/01 22:30:20, sky wrote:
> > Should this be USE_X11?
> 
> By this I mean:
> if defined(USE_X11) && !defined(OS_CHROMEOS)?

Done.

[sky, 2014-05-01 22:58:27]

LGTM

[Elliot Glaysher, 2014-05-01 22:59:27]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-05-01 23:00:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/266643003/40001

[commit-bot: I haz the power, 2014-05-02 01:25:45]

Change committed as 267718