Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 26664008: Add a gesture handler which toggles overview when swiping from the top with three fingers. (Closed)

Created:
7 years, 2 months ago by flackr
Modified:
7 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add a gesture handler which toggles overview when swiping from the top with three fingers. BUG=263528 TEST=Swipe down from the top of the screen with three fingers to toggle overview. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228186

Patch Set 1 : . #

Total comments: 5

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -32 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M ash/ash.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
A ash/wm/gestures/overview_gesture_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ash/wm/gestures/overview_gesture_handler.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
M ash/wm/overview/window_overview.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_overview.cc View 1 chunk +16 lines, -23 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
flackr
PTAL, thanks!
7 years, 2 months ago (2013-10-10 15:31:26 UTC) #1
James Cook
LGTM with a couple nits and a question https://codereview.chromium.org/26664008/diff/3001/ash/wm/gestures/overview_gesture_handler.cc File ash/wm/gestures/overview_gesture_handler.cc (right): https://codereview.chromium.org/26664008/diff/3001/ash/wm/gestures/overview_gesture_handler.cc#newcode42 ash/wm/gestures/overview_gesture_handler.cc:42: event.location().y(); ...
7 years, 2 months ago (2013-10-10 17:11:11 UTC) #2
flackr
https://codereview.chromium.org/26664008/diff/3001/ash/wm/gestures/overview_gesture_handler.cc File ash/wm/gestures/overview_gesture_handler.cc (right): https://codereview.chromium.org/26664008/diff/3001/ash/wm/gestures/overview_gesture_handler.cc#newcode42 ash/wm/gestures/overview_gesture_handler.cc:42: event.location().y(); On 2013/10/10 17:11:12, James Cook wrote: > it ...
7 years, 2 months ago (2013-10-10 17:59:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/26664008/10001
7 years, 2 months ago (2013-10-10 18:01:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=87638
7 years, 2 months ago (2013-10-11 04:14:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/26664008/10001
7 years, 2 months ago (2013-10-11 14:06:11 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 15:04:44 UTC) #7
Message was sent while issue was closed.
Change committed as 228186

Powered by Google App Engine
This is Rietveld 408576698