Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 266633010: Use skia discardable memory for decoded images on Android. (Closed)

Created:
6 years, 7 months ago by reveman
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use skia discardable memory for decoded images on Android. BUG=330041 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reveman
Let's enable this now that our ashmem implementation should be able to handle it properly. ...
6 years, 7 months ago (2014-05-02 16:43:24 UTC) #1
Philippe
lgtm
6 years, 7 months ago (2014-05-05 08:20:29 UTC) #2
reveman
+schenney
6 years, 7 months ago (2014-05-06 02:59:35 UTC) #3
Alpha Left Google
On 2014/05/06 02:59:35, reveman wrote: > +schenney LGTM.
6 years, 7 months ago (2014-05-06 18:48:37 UTC) #4
reveman
senorblanco@, schenney@ for platform/ owner review
6 years, 7 months ago (2014-05-07 14:18:40 UTC) #5
Stephen White
On 2014/05/07 14:18:40, reveman wrote: > senorblanco@, schenney@ for platform/ owner review LGTM
6 years, 7 months ago (2014-05-07 14:34:00 UTC) #6
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-07 14:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/266633010/1
6 years, 7 months ago (2014-05-07 14:57:56 UTC) #8
commit-bot: I haz the power
Change committed as 173540
6 years, 7 months ago (2014-05-07 16:06:35 UTC) #9
Alpha Left Google
On 2014/05/07 16:06:35, I haz the power (commit-bot) wrote: > Change committed as 173540 Looks ...
6 years, 7 months ago (2014-05-08 01:43:03 UTC) #10
boliu
This broke all image rendering on android: crbug.com/371270 Can we revert now and ask questions ...
6 years, 7 months ago (2014-05-08 18:21:08 UTC) #11
Alpha Left Google
6 years, 7 months ago (2014-05-08 18:27:08 UTC) #12
Message was sent while issue was closed.
On 2014/05/08 18:21:08, boliu wrote:
> This broke all image rendering on android: crbug.com/371270
> 
> Can we revert now and ask questions later?

It's already been reverted long time ago:
https://codereview.chromium.org/274563005

Powered by Google App Engine
This is Rietveld 408576698