Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 266633007: Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 35632)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -7594,6 +7594,9 @@
Integer::Cast(left),
Integer::Cast(right));
SetValue(instr, Bool::Get(result));
+ } else if (left.IsDouble() && right.IsDouble()) {
+ // TODO(srdjan): Implement.
+ SetValue(instr, non_constant_);
} else {
SetValue(instr, non_constant_);
}
@@ -8062,6 +8065,11 @@
}
+void ConstantPropagator::VisitUnboxedConstant(UnboxedConstantInstr* instr) {
+ SetValue(instr, instr->value());
+}
+
+
void ConstantPropagator::VisitConstraint(ConstraintInstr* instr) {
// Should not be used outside of range analysis.
UNREACHABLE();

Powered by Google App Engine
This is Rietveld 408576698