Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 266633007: Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 195
196 void ConstantInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 196 void ConstantInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
197 // The register allocator drops constant definitions that have no uses. 197 // The register allocator drops constant definitions that have no uses.
198 if (!locs()->out(0).IsInvalid()) { 198 if (!locs()->out(0).IsInvalid()) {
199 Register result = locs()->out(0).reg(); 199 Register result = locs()->out(0).reg();
200 __ LoadObject(result, value(), PP); 200 __ LoadObject(result, value(), PP);
201 } 201 }
202 } 202 }
203 203
204 204
205 LocationSummary* UnboxedConstantInstr::MakeLocationSummary(bool opt) const {
206 const intptr_t kNumInputs = 0;
207 return LocationSummary::Make(kNumInputs,
208 Location::RequiresFpuRegister(),
209 LocationSummary::kNoCall);
210 }
211
212
213 void UnboxedConstantInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
214 UNIMPLEMENTED();
215 }
216
217
205 LocationSummary* AssertAssignableInstr::MakeLocationSummary(bool opt) const { 218 LocationSummary* AssertAssignableInstr::MakeLocationSummary(bool opt) const {
206 const intptr_t kNumInputs = 3; 219 const intptr_t kNumInputs = 3;
207 const intptr_t kNumTemps = 0; 220 const intptr_t kNumTemps = 0;
208 LocationSummary* summary = 221 LocationSummary* summary =
209 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall); 222 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
210 summary->set_in(0, Location::RegisterLocation(R0)); // Value. 223 summary->set_in(0, Location::RegisterLocation(R0)); // Value.
211 summary->set_in(1, Location::RegisterLocation(R2)); // Instantiator. 224 summary->set_in(1, Location::RegisterLocation(R2)); // Instantiator.
212 summary->set_in(2, Location::RegisterLocation(R1)); // Type arguments. 225 summary->set_in(2, Location::RegisterLocation(R1)); // Type arguments.
213 summary->set_out(0, Location::RegisterLocation(R0)); 226 summary->set_out(0, Location::RegisterLocation(R0));
214 return summary; 227 return summary;
(...skipping 2409 matching lines...) Expand 10 before | Expand all | Expand 10 after
2624 compiler->GenerateCall(token_pos(), 2637 compiler->GenerateCall(token_pos(),
2625 &label, 2638 &label,
2626 PcDescriptors::kOther, 2639 PcDescriptors::kOther,
2627 locs()); 2640 locs());
2628 __ Drop(ArgumentCount()); // Discard arguments. 2641 __ Drop(ArgumentCount()); // Discard arguments.
2629 } 2642 }
2630 2643
2631 } // namespace dart 2644 } // namespace dart
2632 2645
2633 #endif // defined TARGET_ARCH_ARM64 2646 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698