Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Add started_from_context_menu Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 766f9169211e5dcb66bafc6528ede5c0be923265..4309ac9c0752ebc3e8b267015a84bd3616cad67a 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3363,7 +3363,7 @@ void WebContentsImpl::DidStartNavigationToPendingEntry(const GURL& url,
observer.DidStartNavigationToPendingEntry(url, reload_type);
}
-void WebContentsImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,
+void WebContentsImpl::RequestOpenURL(RenderFrameHost* render_frame_host,
const OpenURLParams& params) {
// OpenURL can blow away the source RFH. Use the process/frame routing ID as a
// weak pointer of sorts.
@@ -3377,7 +3377,8 @@ void WebContentsImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,
for (auto& observer : observers_) {
observer.DidOpenRequestedURL(new_contents, render_frame_host, params.url,
params.referrer, params.disposition,
- params.transition);
+ params.transition,
+ params.started_from_context_menu);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698