Switch RenderViewContextMenu to use RequestOpenURL

components/renderer_context_menu/render_view_context_menu_base.cc

Index: components/renderer_context_menu/render_view_context_menu_base.cc
diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc
index 7f979cf793749eacb2a05ce99fef2b17bae4dfb1..c9e49cba57248504b405dfd41268475ddd7d7d3a 100644
--- a/components/renderer_context_menu/render_view_context_menu_base.cc
+++ b/components/renderer_context_menu/render_view_context_menu_base.cc
@@ -392,11 +392,7 @@ void RenderViewContextMenuBase::OpenURLWithExtraHeaders(
   if (!extra_headers.empty())
     open_url_params.extra_headers = extra_headers;
 
-  WebContents* new_contents = source_web_contents_->OpenURL(open_url_params);
-  if (!new_contents)
-    return;
-
-  NotifyURLOpened(url, new_contents);

[Charlie Reis, 2017/02/02 23:34:22]

This looks like it would be dead code if we remove this call.  Does the
NOTIFICATION_RETARGETING happen somewhere else?  Is it safe to remove
NotifyURLOpened itself?

[nasko, 2017/02/07 19:39:34]

I don't think it is safe to remove. Last time I looked, this is needed for
webNavigation API to dispatch events for newly created WebContents.

[Patrick Noland, 2017/02/10 22:42:55]

Yes, NotifyURLOpened would be dead code and safe to remove. However
NOTIFICATION_RETARGETING is still emitted from Browser::WebContentsCreated. That
might be removable with some additional changes to
WebContentsImpl::CreateNewWindow.

+  source_web_contents_->RequestOpenURL(GetRenderFrameHost(), open_url_params);
 }
 
 bool RenderViewContextMenuBase::IsCustomItemChecked(int id) const {