Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/public/browser/page_navigator.h

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Initialize frame_id to MSG_ROUTING_NONE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/page_navigator.h
diff --git a/content/public/browser/page_navigator.h b/content/public/browser/page_navigator.h
index 945c96ec763622ccb5d52ba036cd723e8867deec..ff668d455c20d62cceaa6e3841106c026e7ca434 100644
--- a/content/public/browser/page_navigator.h
+++ b/content/public/browser/page_navigator.h
@@ -17,6 +17,7 @@
#include "content/public/browser/site_instance.h"
#include "content/public/common/referrer.h"
#include "content/public/common/resource_request_body.h"
+#include "ipc/ipc_message.h"
#include "ui/base/page_transition_types.h"
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
@@ -71,6 +72,12 @@ struct CONTENT_EXPORT OpenURLParams {
// The browser-global FrameTreeNode ID or -1 to indicate the main frame.
int frame_tree_node_id;
+ // Routing id of the source RenderFrameHost.
+ int render_frame_id = MSG_ROUTING_NONE;
Charlie Reis 2017/02/16 00:21:10 nit: source_render_frame_id (This is useful to cl
Patrick Noland 2017/02/16 00:57:12 Done.
+
+ // Process id of the source RenderFrameHost.
+ int render_process_id;
Charlie Reis 2017/02/16 00:21:10 nit: source_process_id Also, we should probably i
Patrick Noland 2017/02/16 00:57:12 How about source_render_process_id?
Charlie Reis 2017/02/16 00:59:39 I'm ok with that.
+
// The disposition requested by the navigation source.
WindowOpenDisposition disposition;

Powered by Google App Engine
This is Rietveld 408576698