Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Requested fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index 3feaa460c847383ceefedd8b3076d46f89b0d485..c11a4c9d452e860c55cde0316d43bf96390bb0b0 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -154,6 +154,7 @@ void WebNavigationEventRouter::Retargeting(const RetargetingDetails* details) {
DCHECK(GetViewType(details->source_web_contents) != VIEW_TYPE_TAB_CONTENTS);
return;
}
+
Patrick Noland 2017/02/14 01:16:16 remove this newline
const FrameNavigationState& frame_navigation_state =
tab_observer->frame_navigation_state();
@@ -383,7 +384,8 @@ void WebNavigationTabObserver::DidOpenRequestedURL(
const GURL& url,
const content::Referrer& referrer,
WindowOpenDisposition disposition,
- ui::PageTransition transition) {
+ ui::PageTransition transition,
+ bool started_from_context_menu) {
if (!navigation_state_.CanSendEvents(source_render_frame_host))
return;

Powered by Google App Engine
This is Rietveld 408576698