Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/renderer_context_menu/render_view_context_menu_base.cc
diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc
index 7f979cf793749eacb2a05ce99fef2b17bae4dfb1..47d09f3213f1a7bb2cce89e3b5d3b841f880162e 100644
--- a/components/renderer_context_menu/render_view_context_menu_base.cc
+++ b/components/renderer_context_menu/render_view_context_menu_base.cc
@@ -392,11 +392,10 @@ void RenderViewContextMenuBase::OpenURLWithExtraHeaders(
if (!extra_headers.empty())
open_url_params.extra_headers = extra_headers;
- WebContents* new_contents = source_web_contents_->OpenURL(open_url_params);
- if (!new_contents)
- return;
+ open_url_params.process_id = render_process_id_;
+ open_url_params.frame_id = render_frame_id_;
- NotifyURLOpened(url, new_contents);
nasko 2017/02/14 00:10:22 Since there are no more calls to this, let's remov
Patrick Noland 2017/02/14 01:16:16 Done.
+ source_web_contents_->OpenURL(open_url_params);
}
bool RenderViewContextMenuBase::IsCustomItemChecked(int id) const {

Powered by Google App Engine
This is Rietveld 408576698