Switch RenderViewContextMenu to use RequestOpenURL

content/public/browser/web_contents_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
@@ skipping 305 matching lines @@
 
   // This method is invoked when a new non-pending navigation entry is created.
   // This corresponds to one NavigationController entry being created
   // (in the case of new navigations) or renavigated to (for back/forward
   // navigations).
   virtual void NavigationEntryCommitted(
       const LoadCommittedDetails& load_details) {}
 
   // This method is invoked when a new WebContents was created in response to
   // an action in the observed WebContents, e.g. a link with target=_blank was
   // clicked. The |source_render_frame_host| is the frame in which the action

[Charlie Reis, 2017/02/02 23:34:22]

Please also mention "Open in new tab" from a context menu as an example, since
it's a notable difference from before.

   // took place.
   virtual void DidOpenRequestedURL(WebContents* new_contents,
                                    RenderFrameHost* source_render_frame_host,
                                    const GURL& url,
                                    const Referrer& referrer,
                                    WindowOpenDisposition disposition,
-                                   ui::PageTransition transition) {}
+                                   ui::PageTransition transition,
+                                   bool started_from_context_meu) {}

[Charlie Reis, 2017/02/02 23:34:22]

nit: started_from_context_menu

 
   // This method is invoked when the renderer process has completed its first
   // paint after a non-empty layout.
   virtual void DidFirstVisuallyNonEmptyPaint() {}
 
   // This method is invoked when the main frame in the renderer process performs
   // the first paint after a navigation.
   virtual void DidFirstPaintAfterLoad(RenderWidgetHost* render_widget_host) {}
 
   // When WebContents::Stop() is called, the WebContents stops loading and then
@@ skipping 167 matching lines @@
   void ResetWebContents();
 
   WebContentsImpl* web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_