Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: content/browser/frame_host/navigator_delegate.h

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Address Charlie's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/invalidate_type.h" 9 #include "content/public/browser/invalidate_type.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 // changed. This method corresponds to 87 // changed. This method corresponds to
88 // WebContents::NotifyNavigationStateChanged. 88 // WebContents::NotifyNavigationStateChanged.
89 virtual void NotifyChangedNavigationState(InvalidateTypes changed_flags) {} 89 virtual void NotifyChangedNavigationState(InvalidateTypes changed_flags) {}
90 90
91 // Notifies the Navigator embedder that a navigation to the pending 91 // Notifies the Navigator embedder that a navigation to the pending
92 // NavigationEntry has started in the browser process. 92 // NavigationEntry has started in the browser process.
93 virtual void DidStartNavigationToPendingEntry(const GURL& url, 93 virtual void DidStartNavigationToPendingEntry(const GURL& url,
94 ReloadType reload_type) {} 94 ReloadType reload_type) {}
95 95
96 // Opens a URL with the given parameters. See PageNavigator::OpenURL, which 96 // Opens a URL with the given parameters. See PageNavigator::OpenURL, which
97 // this forwards to. 97 // this is an alias of.
98 virtual void RequestOpenURL(RenderFrameHostImpl* render_frame_host, 98 virtual WebContents* OpenURL(const OpenURLParams& params) = 0;
99 const OpenURLParams& params) {}
100 99
101 // Returns whether to continue a navigation that needs to transfer to a 100 // Returns whether to continue a navigation that needs to transfer to a
102 // different process between the load start and commit. 101 // different process between the load start and commit.
103 virtual bool ShouldTransferNavigation(bool is_main_frame_navigation); 102 virtual bool ShouldTransferNavigation(bool is_main_frame_navigation);
104 103
105 // Returns whether URLs for aborted browser-initiated navigations should be 104 // Returns whether URLs for aborted browser-initiated navigations should be
106 // preserved in the omnibox. Defaults to false. 105 // preserved in the omnibox. Defaults to false.
107 virtual bool ShouldPreserveAbortedURLs(); 106 virtual bool ShouldPreserveAbortedURLs();
108 107
109 // A RenderFrameHost in the specified |frame_tree_node| started loading a new 108 // A RenderFrameHost in the specified |frame_tree_node| started loading a new
(...skipping 21 matching lines...) Expand all
131 // wants to see passed to the corresponding URLRequest on the IO thread. 130 // wants to see passed to the corresponding URLRequest on the IO thread.
132 // In the case of a navigation to an interstitial, no call will be made to the 131 // In the case of a navigation to an interstitial, no call will be made to the
133 // embedder and |nullptr| is returned. 132 // embedder and |nullptr| is returned.
134 virtual std::unique_ptr<NavigationUIData> GetNavigationUIData( 133 virtual std::unique_ptr<NavigationUIData> GetNavigationUIData(
135 NavigationHandle* navigation_handle); 134 NavigationHandle* navigation_handle);
136 }; 135 };
137 136
138 } // namspace content 137 } // namspace content
139 138
140 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 139 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698