Switch RenderViewContextMenu to use RequestOpenURL

content/public/browser/page_navigator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // PageNavigator defines an interface that can be used to express the user's
 // intention to navigate to a particular URL.  The implementing class should
 // perform the navigation.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
 #define CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
@@ skipping 53 matching lines @@
   scoped_refptr<ResourceRequestBody> post_data;
 
   // Extra headers to add to the request for this page.  Headers are
   // represented as "<name>: <value>" and separated by \r\n.  The entire string
   // is terminated by \r\n.  May be empty if no extra headers are needed.
   std::string extra_headers;
 
   // The browser-global FrameTreeNode ID or -1 to indicate the main frame.
   int frame_tree_node_id;
 
+  // Routing id of the source RenderFrameHost.
+  int render_frame_id;

[nasko, 2017/02/15 00:58:07]

I'm sorry I missed this on the previous iterations, but we should be
initializing these to MSG_ROUTING_NONE when constructing the struct. Otherwise
we can get uninitialized memory with garbage content in it and lead to incorrect
values. 

[Patrick Noland, 2017/02/15 22:30:42]

Done.

+
+  // Process id of the source RenderFrameHost.
+  int render_process_id;
+
   // The disposition requested by the navigation source.
   WindowOpenDisposition disposition;
 
   // The transition type of navigation.
   ui::PageTransition transition;
 
   // Whether this navigation is initiated by the renderer process.
   bool is_renderer_initiated;
 
   // Indicates whether this navigation should replace the current
@@ skipping 18 matching lines @@
   // Opens a URL with the given disposition.  The transition specifies how this
   // navigation should be recorded in the history system (for example, typed).
   // Returns the WebContents the URL is opened in, or nullptr if the URL wasn't
   // opened immediately.
   virtual WebContents* OpenURL(const OpenURLParams& params) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_