Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2666143002: Add a channel to communication with server (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/channel/channel.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 1 chunk +74 lines, -0 lines 2 comments Download
A pkg/analyzer_plugin/test/src/channel/isolate_channel_test.dart View 1 chunk +119 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/src/channel/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/src/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-01-31 20:47:26 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2666143002/diff/1/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart File pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart (right): https://codereview.chromium.org/2666143002/diff/1/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart#newcode15 pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart:15: class IsolateChannel implements PluginCommunicationChannel { Maybe a bit ...
3 years, 10 months ago (2017-01-31 21:00:40 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as d8129ae0c9758ab648bbad6aeda2d0eb0e56bd01 (presubmit successful).
3 years, 10 months ago (2017-01-31 21:07:28 UTC) #5
Brian Wilkerson
3 years, 10 months ago (2017-01-31 21:11:32 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2666143002/diff/1/pkg/analyzer_plugin/lib/src...
File pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart (right):

https://codereview.chromium.org/2666143002/diff/1/pkg/analyzer_plugin/lib/src...
pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart:15: class
IsolateChannel implements PluginCommunicationChannel {
Oops! Too many things going on at one time. I'll catch this in the next CL.

Powered by Google App Engine
This is Rietveld 408576698