Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: runtime/vm/virtual_memory_test.cc

Issue 2666133002: Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w… (Closed)
Patch Set: Renamed unit test macros to better represent what each type of test actually does. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/virtual_memory_test.cc
diff --git a/runtime/vm/virtual_memory_test.cc b/runtime/vm/virtual_memory_test.cc
index cc98c035c2a4e167b8fffb62214f35ec7c28b370..c652f8c2b61ad7c32aab287b00b9176c8b4a014d 100644
--- a/runtime/vm/virtual_memory_test.cc
+++ b/runtime/vm/virtual_memory_test.cc
@@ -18,7 +18,7 @@ bool IsZero(char* begin, char* end) {
}
-UNIT_TEST_CASE(AllocateVirtualMemory) {
+VM_UNIT_TEST_CASE(AllocateVirtualMemory) {
const intptr_t kVirtualMemoryBlockSize = 64 * KB;
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
EXPECT(vm != NULL);
@@ -52,7 +52,7 @@ UNIT_TEST_CASE(AllocateVirtualMemory) {
}
-UNIT_TEST_CASE(FreeVirtualMemory) {
+VM_UNIT_TEST_CASE(FreeVirtualMemory) {
// Reservations should always be handed back to OS upon destruction.
const intptr_t kVirtualMemoryBlockSize = 10 * MB;
const intptr_t kIterations = 900; // Enough to exhaust 32-bit address space.
@@ -89,7 +89,7 @@ UNIT_TEST_CASE(FreeVirtualMemory) {
}
-UNIT_TEST_CASE(VirtualMemoryCommitPartial) {
+VM_UNIT_TEST_CASE(VirtualMemoryCommitPartial) {
const intptr_t kVirtualMemoryBlockSize = 3 * MB;
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
EXPECT(vm != NULL);

Powered by Google App Engine
This is Rietveld 408576698