runtime/vm/cpuinfo_test.cc - Issue 2666133002: Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cpuinfo_test.cc

Issue 2666133002: Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w… (Closed)

Patch Set: Renamed unit test macros to better represent what each type of test actually does. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/cpuinfo_test.cc

diff --git a/runtime/vm/cpuinfo_test.cc b/runtime/vm/cpuinfo_test.cc

index 0b6113b75b9b2567d510f76454ee8777237f2011..2d8434e1e473d0de43bfd55dc924ae15a6018fdc 100644

--- a/runtime/vm/cpuinfo_test.cc

+++ b/runtime/vm/cpuinfo_test.cc

@@ -9,7 +9,7 @@

namespace dart {

-UNIT_TEST_CASE(GetCpuModelTest) {

+VM_UNIT_TEST_CASE(GetCpuModelTest) {

const char* cpumodel = CpuInfo::GetCpuModel();

EXPECT_NE(strlen(cpumodel), 0UL);

// caller is responsible for deleting the returned cpumodel string.