Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w…

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "include/dart_tools_api.h"
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/clustered_snapshot.h"
@@ skipping 984 matching lines @@
   // Check if we are able to generate the source from the token stream.
   // Rescan this source and compare the token stream to see if they are
   // the same.
   GenerateSourceAndCheck(serialized_script);
 
   free(buffer);
 }
 
 
 #if !defined(PRODUCT)  // Uses deferred loading.
-UNIT_TEST_CASE(CanonicalizationInScriptSnapshots) {
+VM_UNIT_TEST_CASE(CanonicalizationInScriptSnapshots) {
   const char* kScriptChars =
       "\n"
       "import 'dart:mirrors';"
       "import 'dart:isolate';"
       "void main() {"
       "  if (reflectClass(MyException).superclass.reflectedType != "
       "      IsolateSpawnException) {"
       "    throw new Exception('Canonicalization failure');"
       "  }"
       "  if (reflectClass(IsolateSpawnException).reflectedType != "
@@ skipping 98 matching lines @@
   String& uri = String::Handle();
   for (intptr_t i = 0; i < lib_scripts.Length(); i++) {
     script ^= lib_scripts.At(i);
     EXPECT(!script.IsNull());
     uri = script.url();
     OS::Print("Generating source for part: %s\n", uri.ToCString());
     GenerateSourceAndCheck(script);
   }
 }
 
-VM_TEST_CASE(GenerateSource) {
+ISOLATE_UNIT_TEST_CASE(GenerateSource) {
   Zone* zone = thread->zone();
   Isolate* isolate = thread->isolate();
   const GrowableObjectArray& libs =
       GrowableObjectArray::Handle(zone, isolate->object_store()->libraries());
   Library& lib = Library::Handle();
   String& uri = String::Handle();
   for (intptr_t i = 0; i < libs.Length(); i++) {
     lib ^= libs.At(i);
     EXPECT(!lib.IsNull());
     uri = lib.url();
     OS::Print("Generating source for library: %s\n", uri.ToCString());
     IterateScripts(lib);
   }
 }
 
 
-UNIT_TEST_CASE(FullSnapshot) {
+VM_UNIT_TEST_CASE(FullSnapshot) {
   const char* kScriptChars =
       "class Fields  {\n"
       "  Fields(int i, int j) : fld1 = i, fld2 = j {}\n"
       "  int fld1;\n"
       "  final int fld2;\n"
       "  final int bigint_fld = 0xfffffffffff;\n"
       "  static int fld3;\n"
       "  static const int smi_sfld = 10;\n"
       "  static const int bigint_sfld = 0xfffffffffff;\n"
       "}\n"
@@ skipping 53 matching lines @@
     Dart_Handle cls = Dart_GetClass(TestCase::lib(), NewString("FieldsTest"));
     result = Dart_Invoke(cls, NewString("testMain"), 0, NULL);
     EXPECT_VALID(result);
     Dart_ExitScope();
   }
   Dart_ShutdownIsolate();
   free(isolate_snapshot_data_buffer);
 }
 
 
-UNIT_TEST_CASE(FullSnapshot1) {
+VM_UNIT_TEST_CASE(FullSnapshot1) {
   // This buffer has to be static for this to compile with Visual Studio.
   // If it is not static compilation of this file with Visual Studio takes
   // more than 30 minutes!
   static const char kFullSnapshotScriptChars[] = {
 #include "snapshot_test.dat"
   };
   const char* kScriptChars = kFullSnapshotScriptChars;
 
   uint8_t* isolate_snapshot_data_buffer;
 
@@ skipping 48 matching lines @@
     Dart_ExitScope();
   }
   Dart_ShutdownIsolate();
   free(isolate_snapshot_data_buffer);
 }
 
 
 #ifndef PRODUCT
 
 
-UNIT_TEST_CASE(ScriptSnapshot) {
+VM_UNIT_TEST_CASE(ScriptSnapshot) {
   const char* kLibScriptChars =
       "library dart_import_lib;"
       "class LibFields  {"
       "  LibFields(int i, int j) : fld1 = i, fld2 = j {}"
       "  int fld1;"
       "  final int fld2;"
       "}";
   const char* kScriptChars =
       "class TestTrace implements StackTrace {"
       "  TestTrace();"
@@ skipping 114 matching lines @@
     result = Dart_Invoke(cls, NewString("testMain"), 0, NULL);
     EXPECT_VALID(result);
     Dart_ExitScope();
     Dart_ShutdownIsolate();
   }
   free(full_snapshot);
   free(script_snapshot);
 }
 
 
-UNIT_TEST_CASE(ScriptSnapshot1) {
+VM_UNIT_TEST_CASE(ScriptSnapshot1) {
   const char* kScriptChars =
       "class _SimpleNumEnumerable<T extends num> {"
       "final Iterable<T> _source;"
       "const _SimpleNumEnumerable(this._source) : super();"
       "}";
 
   Dart_Handle result;
   uint8_t* buffer;
   intptr_t size;
   intptr_t vm_isolate_snapshot_size;
@@ skipping 52 matching lines @@
     Dart_ExitScope();
   }
 
   FLAG_load_deferred_eagerly = saved_load_deferred_eagerly_mode;
   Dart_ShutdownIsolate();
   free(full_snapshot);
   free(script_snapshot);
 }
 
 
-UNIT_TEST_CASE(ScriptSnapshot2) {
+VM_UNIT_TEST_CASE(ScriptSnapshot2) {
   // The snapshot of this library is always created in production mode, but
   // loaded and executed in both production and checked modes.
   // This test verifies that type information is still contained in the snapshot
   // although it was created in production mode and that type errors and
   // compilation errors (for const fields) are correctly reported according to
   // the execution mode.
   const char* kLibScriptChars =
       "library dart_import_lib;"
       "const String s = 1.0;"
       "final int i = true;"
@@ skipping 95 matching lines @@
     result = Dart_Invoke(lib, NewString("test_b"), 0, NULL);
     EXPECT(Dart_IsError(result) == saved_enable_type_checks_mode);
     Dart_ExitScope();
   }
   Dart_ShutdownIsolate();
   free(full_snapshot);
   free(script_snapshot);
 }
 
 
-UNIT_TEST_CASE(MismatchedSnapshotKinds) {
+VM_UNIT_TEST_CASE(MismatchedSnapshotKinds) {
   const char* kScriptChars = "main() { print('Hello, world!'); }";
   Dart_Handle result;
 
   uint8_t* buffer;
   intptr_t size;
   intptr_t vm_isolate_snapshot_size;
   uint8_t* isolate_snapshot = NULL;
   intptr_t isolate_snapshot_size;
   uint8_t* full_snapshot = NULL;
   uint8_t* script_snapshot = NULL;
@@ skipping 155 matching lines @@
 
   // Read object back from the snapshot into a C structure.
   ApiNativeScope scope;
   ApiMessageReader api_reader(buffer, buffer_len);
   Dart_CObject* root = api_reader.ReadMessage();
   EXPECT_NOTNULL(root);
   EXPECT_EQ(Dart_CObject_kUnsupported, root->type);
 }
 
 
-UNIT_TEST_CASE(DartGeneratedMessages) {
+VM_UNIT_TEST_CASE(DartGeneratedMessages) {
   static const char* kCustomIsolateScriptChars =
       "getSmi() {\n"
       "  return 42;\n"
       "}\n"
       "getBigint() {\n"
       "  return -0x424242424242424242424242424242424242;\n"
       "}\n"
       "getAsciiString() {\n"
       "  return \"Hello, world!\";\n"
       "}\n"
@@ skipping 127 matching lines @@
     CheckStringInvalid(lead_surrogate_string_result);
     CheckStringInvalid(trail_surrogate_string_result);
     CheckStringInvalid(crappy_string_result);
     CheckStringInvalid(surrogates_string_result);
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
-UNIT_TEST_CASE(DartGeneratedListMessages) {
+VM_UNIT_TEST_CASE(DartGeneratedListMessages) {
   const int kArrayLength = 10;
   static const char* kScriptChars =
       "final int kArrayLength = 10;\n"
       "getList() {\n"
       "  return new List(kArrayLength);\n"
       "}\n"
       "getIntList() {\n"
       "  var list = new List<int>(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = i;\n"
       "  return list;\n"
@@ skipping 90 matching lines @@
           EXPECT_EQ(Dart_CObject_kNull, root->value.as_array.values[i]->type);
         }
       }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
-UNIT_TEST_CASE(DartGeneratedArrayLiteralMessages) {
+VM_UNIT_TEST_CASE(DartGeneratedArrayLiteralMessages) {
   const int kArrayLength = 10;
   static const char* kScriptChars =
       "final int kArrayLength = 10;\n"
       "getList() {\n"
       "  return [null, null, null, null, null, null, null, null, null, null];\n"
       "}\n"
       "getIntList() {\n"
       "  return [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];\n"
       "}\n"
       "getStringList() {\n"
@@ skipping 200 matching lines @@
         EXPECT_EQ(Dart_CObject_kInt32, e->type);
         EXPECT_EQ(i + 1, e->value.as_int32);
       }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
-UNIT_TEST_CASE(DartGeneratedListMessagesWithBackref) {
+VM_UNIT_TEST_CASE(DartGeneratedListMessagesWithBackref) {
   const int kArrayLength = 10;
   static const char* kScriptChars =
       "import 'dart:typed_data';\n"
       "final int kArrayLength = 10;\n"
       "getStringList() {\n"
       "  var s = 'Hello, world!';\n"
       "  var list = new List<String>(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = s;\n"
       "  return list;\n"
       "}\n"
@@ skipping 199 matching lines @@
         EXPECT_EQ(Dart_CObject_kArray, element->type);
         EXPECT_EQ(root, element);
       }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
-UNIT_TEST_CASE(DartGeneratedArrayLiteralMessagesWithBackref) {
+VM_UNIT_TEST_CASE(DartGeneratedArrayLiteralMessagesWithBackref) {
   const int kArrayLength = 10;
   static const char* kScriptChars =
       "import 'dart:typed_data';\n"
       "final int kArrayLength = 10;\n"
       "getStringList() {\n"
       "  var s = 'Hello, world!';\n"
       "  var list = [s, s, s, s, s, s, s, s, s, s];\n"
       "  return list;\n"
       "}\n"
       "getMintList() {\n"
@@ skipping 214 matching lines @@
 
 
 static void CheckTypedData(Dart_CObject* object,
                            Dart_TypedData_Type typed_data_type,
                            int len) {
   EXPECT_EQ(Dart_CObject_kTypedData, object->type);
   EXPECT_EQ(typed_data_type, object->value.as_typed_data.type);
   EXPECT_EQ(len, object->value.as_typed_data.length);
 }
 
-UNIT_TEST_CASE(DartGeneratedListMessagesWithTypedData) {
+VM_UNIT_TEST_CASE(DartGeneratedListMessagesWithTypedData) {
   static const char* kScriptChars =
       "import 'dart:typed_data';\n"
       "getTypedDataList() {\n"
       "  var list = new List(10);\n"
       "  var index = 0;\n"
       "  list[index++] = new Int8List(256);\n"
       "  list[index++] = new Uint8List(256);\n"
       "  list[index++] = new Int16List(256);\n"
       "  list[index++] = new Uint16List(256);\n"
       "  list[index++] = new Int32List(256);\n"
@@ skipping 166 matching lines @@
         i++;
       }
       EXPECT_EQ(i, root->value.as_array.length);
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
-UNIT_TEST_CASE(PostCObject) {
+VM_UNIT_TEST_CASE(PostCObject) {
   // Create a native port for posting from C to Dart
   TestIsolateScope __test_isolate__;
   const char* kScriptChars =
       "import 'dart:isolate';\n"
       "main() {\n"
       "  var messageCount = 0;\n"
       "  var exception = '';\n"
       "  var port = new RawReceivePort();\n"
       "  var sendPort = port.sendPort;\n"
       "  port.handler = (message) {\n"
@@ skipping 86 matching lines @@
   StackZone zone(Thread::Current());
   uint8_t* buffer;
   MessageWriter writer(&buffer, &zone_allocator, &zone_deallocator, true);
   writer.WriteInlinedObjectHeader(kOmittedObjectId);
   // For performance, we'd like single-byte headers when ids are omitted.
   // If this starts failing, consider renumbering the snapshot ids.
   EXPECT_EQ(1, writer.BytesWritten());
 }
 
 }  // namespace dart