Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/json_schema_compiler/test/crossref_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/crossref_unittest.cc
diff --git a/tools/json_schema_compiler/test/crossref_unittest.cc b/tools/json_schema_compiler/test/crossref_unittest.cc
index 4c72369f987457cd12508d8a33daa634385363a6..75406ea13efa3eff191aad5726376c784ea31d5f 100644
--- a/tools/json_schema_compiler/test/crossref_unittest.cc
+++ b/tools/json_schema_compiler/test/crossref_unittest.cc
@@ -16,10 +16,10 @@ namespace {
std::unique_ptr<base::DictionaryValue> CreateTestTypeValue() {
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
- value->Set("number", new base::FundamentalValue(1.1));
- value->Set("integer", new base::FundamentalValue(4));
+ value->Set("number", new base::Value(1.1));
+ value->Set("integer", new base::Value(4));
value->Set("string", new base::StringValue("bling"));
- value->Set("boolean", new base::FundamentalValue(true));
+ value->Set("boolean", new base::Value(true));
return value;
}
@@ -89,7 +89,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
std::unique_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
param_object_value->Set("testType", CreateTestTypeValue().release());
- param_object_value->Set("boolean", new base::FundamentalValue(true));
+ param_object_value->Set("boolean", new base::Value(true));
params_value->Append(std::move(param_object_value));
std::unique_ptr<crossref::TestTypeInObject::Params> params(
crossref::TestTypeInObject::Params::Create(*params_value));
@@ -103,7 +103,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
std::unique_ptr<base::ListValue> params_value(new base::ListValue());
std::unique_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
- param_object_value->Set("boolean", new base::FundamentalValue(true));
+ param_object_value->Set("boolean", new base::Value(true));
params_value->Append(std::move(param_object_value));
std::unique_ptr<crossref::TestTypeInObject::Params> params(
crossref::TestTypeInObject::Params::Create(*params_value));
@@ -116,7 +116,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
std::unique_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
param_object_value->Set("testType", new base::StringValue("invalid"));
- param_object_value->Set("boolean", new base::FundamentalValue(true));
+ param_object_value->Set("boolean", new base::Value(true));
params_value->Append(std::move(param_object_value));
std::unique_ptr<crossref::TestTypeInObject::Params> params(
crossref::TestTypeInObject::Params::Create(*params_value));
« no previous file with comments | « tools/json_schema_compiler/test/choices_unittest.cc ('k') | tools/json_schema_compiler/test/error_generation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698