tools/json_schema_compiler/cc_generator.py - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 3fd3d2a2b241b23f7b0d4b1e71000306baa58225..b653a9c83bc862e8a2443cfe051fbd16448c0185 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -650,7 +650,7 @@ class _Generator(object):

if underlying_type.property_type == PropertyType.STRING:

return 'base::MakeUnique<base::StringValue>(%s)' % var

else:

- return 'base::MakeUnique<base::FundamentalValue>(%s)' % var

+ return 'base::MakeUnique<base::Value>(%s)' % var

else:

raise NotImplementedError('Conversion of %s to base::Value not '

'implemented' % repr(type_.type_))

« no previous file with comments | « tools/ipc_fuzzer/fuzzer/fuzzer.cc ('k') | tools/json_schema_compiler/test/any_unittest.cc » ('j') | no next file with comments »