ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/internal/value_conversions.h ('k') | ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc b/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc

index d2ac247e83a211adda8525ce0ecc1a4fa7fc0aef..e3c3094070ae9d1cfe50fd2869670705950dd7f4 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc

@@ -29,7 +29,7 @@ class IOSChromeMetricsServiceAccessorTest : public testing::Test {

TEST_F(IOSChromeMetricsServiceAccessorTest, MetricsReportingEnabled) {

#if defined(GOOGLE_CHROME_BUILD)

const char* pref = metrics::prefs::kMetricsReportingEnabled;

- GetLocalState()->SetDefaultPrefValue(pref, new base::FundamentalValue(false));

+ GetLocalState()->SetDefaultPrefValue(pref, new base::Value(false));

GetLocalState()->SetBoolean(pref, false);

EXPECT_FALSE(