extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/rules_cache_delegate.cc ('k') | extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index a628def301ebdf5b14daa12894973aeeffb3ffe6..1dfaac96854b567a16e3fb72a485c85dd8737448 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -26,7 +26,6 @@

#include "testing/gtest/include/gtest/gtest.h"

using base::DictionaryValue;

-using base::FundamentalValue;

using base::ListValue;

using base::StringValue;

using base::Value;

@@ -208,7 +207,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {

base::MessageLoopForIO message_loop;

std::string error;

- const FundamentalValue value_true(true);

+ const Value value_true(true);

// This attribute matches only third party requests.

scoped_refptr<const WebRequestConditionAttribute> third_party_attribute =

WebRequestConditionAttribute::Create(keys::kThirdPartyKey,

@@ -218,7 +217,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {

ASSERT_TRUE(third_party_attribute.get());

EXPECT_EQ(std::string(keys::kThirdPartyKey),

third_party_attribute->GetName());

- const FundamentalValue value_false(false);

+ const Value value_false(false);

// This attribute matches only first party requests.

scoped_refptr<const WebRequestConditionAttribute> first_party_attribute =

WebRequestConditionAttribute::Create(keys::kThirdPartyKey,