Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index 9b6e70d415070261a73cf4e710b26cc5438ef6d9..10d91fbdd1084e1c08d2d20b1973ab51464980ab 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -198,7 +198,7 @@ bool AppWindowCreateFunction::RunAsync() {
std::unique_ptr<base::DictionaryValue> result(
new base::DictionaryValue);
- result->Set("frameId", new base::FundamentalValue(frame_id));
+ result->Set("frameId", new base::Value(frame_id));
existing_window->GetSerializedState(result.get());
result->SetBoolean("existingWindow", true);
SetResult(std::move(result));
@@ -381,7 +381,7 @@ bool AppWindowCreateFunction::RunAsync() {
frame_id = created_frame->GetRoutingID();
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
- result->Set("frameId", new base::FundamentalValue(frame_id));
+ result->Set("frameId", new base::Value(frame_id));
result->Set("id", new base::StringValue(app_window->window_key()));
app_window->GetSerializedState(result.get());
SetResult(std::move(result));
« no previous file with comments | « extensions/browser/api/alarms/alarms_api.cc ('k') | extensions/browser/api/declarative/rules_cache_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698