Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/tracing/etw_tracing_agent_win.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/etw_tracing_agent_win.cc
diff --git a/content/browser/tracing/etw_tracing_agent_win.cc b/content/browser/tracing/etw_tracing_agent_win.cc
index 0b934a611f477e2dd4e4a6ce4cef24a9748394c3..8d4cfa20ea8e17f60059519d5bdabf0a7a5cc5ff 100644
--- a/content/browser/tracing/etw_tracing_agent_win.cc
+++ b/content/browser/tracing/etw_tracing_agent_win.cc
@@ -181,7 +181,7 @@ void EtwTracingAgent::AddSyncEventToBuffer() {
}
void EtwTracingAgent::AppendEventToBuffer(EVENT_TRACE* event) {
- using base::FundamentalValue;
+ using base::Value;
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
@@ -193,13 +193,11 @@ void EtwTracingAgent::AppendEventToBuffer(EVENT_TRACE* event) {
value->Set("guid", new base::StringValue(GuidToString(event->Header.Guid)));
- value->Set("op", new FundamentalValue(event->Header.Class.Type));
- value->Set("ver", new FundamentalValue(event->Header.Class.Version));
- value->Set("pid",
- new FundamentalValue(static_cast<int>(event->Header.ProcessId)));
- value->Set("tid",
- new FundamentalValue(static_cast<int>(event->Header.ThreadId)));
- value->Set("cpu", new FundamentalValue(event->BufferContext.ProcessorNumber));
+ value->Set("op", new Value(event->Header.Class.Type));
+ value->Set("ver", new Value(event->Header.Class.Version));
+ value->Set("pid", new Value(static_cast<int>(event->Header.ProcessId)));
+ value->Set("tid", new Value(static_cast<int>(event->Header.ThreadId)));
+ value->Set("cpu", new Value(event->BufferContext.ProcessorNumber));
// Base64 encode the payload bytes.
base::StringPiece buffer(static_cast<const char*>(event->MofData),
« no previous file with comments | « content/browser/service_worker/service_worker_internals_ui.cc ('k') | content/browser/tracing/tracing_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698