components/search_engines/default_search_policy_handler_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/default_search_policy_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/default_search_manager_unittest.cc ('k') | components/search_engines/template_url_prepopulate_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/default_search_policy_handler_unittest.cc

diff --git a/components/search_engines/default_search_policy_handler_unittest.cc b/components/search_engines/default_search_policy_handler_unittest.cc

index 70d8a83c2a9453b5855deaa89765c465a82e4686..02b9dcdf5cc288aa2809f50e7f3f706baad3b089 100644

--- a/components/search_engines/default_search_policy_handler_unittest.cc

+++ b/components/search_engines/default_search_policy_handler_unittest.cc

@@ -81,7 +81,7 @@ void DefaultSearchPolicyHandlerTest::

encodings->AppendString("UTF-8");

policy->Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::FundamentalValue>(true), nullptr);

+ base::MakeUnique<base::Value>(true), nullptr);

policy->Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

base::MakeUnique<base::StringValue>(kSearchURL), nullptr);

@@ -263,7 +263,7 @@ TEST_F(DefaultSearchPolicyHandlerTest, Disabled) {

PolicyMap policy;

policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(false)), nullptr);

+ base::WrapUnique(new base::Value(false)), nullptr);

UpdateProviderPolicy(policy);

const base::Value* temp = NULL;

const base::DictionaryValue* dictionary;

@@ -282,7 +282,7 @@ TEST_F(DefaultSearchPolicyHandlerTest, MinimallyDefined) {

PolicyMap policy;

policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(true)), nullptr);

+ base::WrapUnique(new base::Value(true)), nullptr);

policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

base::WrapUnique(new base::StringValue(kSearchURL)), nullptr);

@@ -341,7 +341,7 @@ TEST_F(DefaultSearchPolicyHandlerTest, FileURL) {

PolicyMap policy;

policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(true)), nullptr);

+ base::WrapUnique(new base::Value(true)), nullptr);

policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

base::WrapUnique(new base::StringValue(kFileSearchURL)), nullptr);