Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: components/policy/tools/generate_policy_source_test.py

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/tools/generate_policy_source.py ('k') | components/prefs/command_line_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/tools/generate_policy_source_test.py
diff --git a/components/policy/tools/generate_policy_source_test.py b/components/policy/tools/generate_policy_source_test.py
index 44fa29a0d88c180a525b2f19d73f41d81232334e..9de1bbba459e4b4a0a1bf6a8c061447b454b377c 100755
--- a/components/policy/tools/generate_policy_source_test.py
+++ b/components/policy/tools/generate_policy_source_test.py
@@ -13,15 +13,15 @@ class CppGenerationTest(unittest.TestCase):
# Bools
stmts, expr = generate_policy_source._GenerateDefaultValue(True)
self.assertListEqual([], stmts)
- self.assertEqual('base::MakeUnique<base::FundamentalValue>(true)', expr)
+ self.assertEqual('base::MakeUnique<base::Value>(true)', expr)
stmts, expr = generate_policy_source._GenerateDefaultValue(False)
self.assertListEqual([], stmts)
- self.assertEqual('base::MakeUnique<base::FundamentalValue>(false)', expr)
+ self.assertEqual('base::MakeUnique<base::Value>(false)', expr)
# Ints
stmts, expr = generate_policy_source._GenerateDefaultValue(33)
self.assertListEqual([], stmts)
- self.assertEqual('base::MakeUnique<base::FundamentalValue>(33)', expr)
+ self.assertEqual('base::MakeUnique<base::Value>(33)', expr)
# Strings
stmts, expr = generate_policy_source._GenerateDefaultValue('foo')
@@ -38,7 +38,7 @@ class CppGenerationTest(unittest.TestCase):
stmts, expr = generate_policy_source._GenerateDefaultValue([1, '2'])
self.assertListEqual([
'auto default_value = base::MakeUnique<base::ListValue>();',
- 'default_value->Append(base::MakeUnique<base::FundamentalValue>(1));',
+ 'default_value->Append(base::MakeUnique<base::Value>(1));',
'default_value->Append(base::MakeUnique<base::StringValue>("2"));'
], stmts)
self.assertEqual('std::move(default_value)', expr)
« no previous file with comments | « components/policy/tools/generate_policy_source.py ('k') | components/prefs/command_line_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698