Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
diff --git a/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc b/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
index 2d0260495d1ffbc82809727ead65caaaeeb7fbfe..7c91a7b3c23f991461169e87baec0f807a06d42e 100644
--- a/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
+++ b/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
@@ -68,8 +68,8 @@ TEST_F(URLBlacklistPolicyHandlerTest,
TEST_F(URLBlacklistPolicyHandlerTest,
CheckPolicySettings_DisabledSchemesWrongType) {
// The policy expects a list. Give it a boolean.
- EXPECT_TRUE(CheckPolicy(key::kDisabledSchemes,
- base::MakeUnique<base::FundamentalValue>(false)));
+ EXPECT_TRUE(
+ CheckPolicy(key::kDisabledSchemes, base::MakeUnique<base::Value>(false)));
EXPECT_EQ(1U, errors_.size());
const std::string expected = key::kDisabledSchemes;
const std::string actual = errors_.begin()->first;
@@ -79,8 +79,8 @@ TEST_F(URLBlacklistPolicyHandlerTest,
TEST_F(URLBlacklistPolicyHandlerTest,
CheckPolicySettings_URLBlacklistWrongType) {
// The policy expects a list. Give it a boolean.
- EXPECT_TRUE(CheckPolicy(key::kURLBlacklist,
- base::MakeUnique<base::FundamentalValue>(false)));
+ EXPECT_TRUE(
+ CheckPolicy(key::kURLBlacklist, base::MakeUnique<base::Value>(false)));
EXPECT_EQ(1U, errors_.size());
const std::string expected = key::kURLBlacklist;
const std::string actual = errors_.begin()->first;
@@ -95,8 +95,7 @@ TEST_F(URLBlacklistPolicyHandlerTest, ApplyPolicySettings_NothingSpecified) {
TEST_F(URLBlacklistPolicyHandlerTest,
ApplyPolicySettings_DisabledSchemesWrongType) {
// The policy expects a list. Give it a boolean.
- SetPolicy(key::kDisabledSchemes,
- base::MakeUnique<base::FundamentalValue>(false));
+ SetPolicy(key::kDisabledSchemes, base::MakeUnique<base::Value>(false));
ApplyPolicies();
EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));
}
@@ -104,8 +103,7 @@ TEST_F(URLBlacklistPolicyHandlerTest,
TEST_F(URLBlacklistPolicyHandlerTest,
ApplyPolicySettings_URLBlacklistWrongType) {
// The policy expects a list. Give it a boolean.
- SetPolicy(key::kURLBlacklist,
- base::MakeUnique<base::FundamentalValue>(false));
+ SetPolicy(key::kURLBlacklist, base::MakeUnique<base::Value>(false));
ApplyPolicies();
EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));
}

Powered by Google App Engine
This is Rietveld 408576698