Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.mm

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_page_ios.mm
diff --git a/components/dom_distiller/ios/distiller_page_ios.mm b/components/dom_distiller/ios/distiller_page_ios.mm
index f3eed985dbad8059799632732ec635f3668c53c7..4773be550d69ed4dd1a3d75941a6588e815f6aba 100644
--- a/components/dom_distiller/ios/distiller_page_ios.mm
+++ b/components/dom_distiller/ios/distiller_page_ios.mm
@@ -55,16 +55,15 @@ std::unique_ptr<base::Value> ValueResultFromScriptResult(id wk_result,
} else if (result_type == CFNumberGetTypeID()) {
// Different implementation is here.
if ([wk_result intValue] != [wk_result doubleValue]) {
- result.reset(new base::FundamentalValue([wk_result doubleValue]));
+ result.reset(new base::Value([wk_result doubleValue]));
DCHECK(result->IsType(base::Value::Type::DOUBLE));
} else {
- result.reset(new base::FundamentalValue([wk_result intValue]));
+ result.reset(new base::Value([wk_result intValue]));
DCHECK(result->IsType(base::Value::Type::INTEGER));
}
// End of different implementation.
} else if (result_type == CFBooleanGetTypeID()) {
- result.reset(
- new base::FundamentalValue(static_cast<bool>([wk_result boolValue])));
+ result.reset(new base::Value(static_cast<bool>([wk_result boolValue])));
DCHECK(result->IsType(base::Value::Type::BOOLEAN));
} else if (result_type == CFNullGetTypeID()) {
result = base::Value::CreateNullValue();

Powered by Google App Engine
This is Rietveld 408576698