components/content_settings/core/browser/content_settings_rule_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_rule_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_registry.cc ('k') | components/content_settings/core/browser/content_settings_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_rule_unittest.cc

diff --git a/components/content_settings/core/browser/content_settings_rule_unittest.cc b/components/content_settings/core/browser/content_settings_rule_unittest.cc

index b0fca26c68d5a9d2cac9953ac95d5dd11f908ae9..ab218fb4e0248fd785bec89356f7ea3872490d70 100644

--- a/components/content_settings/core/browser/content_settings_rule_unittest.cc

+++ b/components/content_settings/core/browser/content_settings_rule_unittest.cc

@@ -42,17 +42,17 @@ TEST(RuleTest, ConcatenationIterator) {

std::list<Rule> rules1;

rules1.push_back(Rule(ContentSettingsPattern::FromString("a"),

ContentSettingsPattern::Wildcard(),

- new base::FundamentalValue(0)));

+ new base::Value(0)));

rules1.push_back(Rule(ContentSettingsPattern::FromString("b"),

ContentSettingsPattern::Wildcard(),

- new base::FundamentalValue(0)));

+ new base::Value(0)));

std::list<Rule> rules2;

rules2.push_back(Rule(ContentSettingsPattern::FromString("c"),

ContentSettingsPattern::Wildcard(),

- new base::FundamentalValue(0)));

+ new base::Value(0)));

rules2.push_back(Rule(ContentSettingsPattern::FromString("d"),

ContentSettingsPattern::Wildcard(),

- new base::FundamentalValue(0)));

+ new base::Value(0)));

std::vector<std::unique_ptr<RuleIterator>> iterators;

iterators.push_back(std::unique_ptr<RuleIterator>(new ListIterator(rules1)));