Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5091)

Unified Diff: chromeos/network/shill_property_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler_unittest.cc
diff --git a/chromeos/network/shill_property_handler_unittest.cc b/chromeos/network/shill_property_handler_unittest.cc
index e5cc6ffdfe857827aff01d3e1137fe2b9aa44050..35d8c74d9e8587c4524cde6d93824a4cebed54e6 100644
--- a/chromeos/network/shill_property_handler_unittest.cc
+++ b/chromeos/network/shill_property_handler_unittest.cc
@@ -383,7 +383,7 @@ TEST_F(ShillPropertyHandlerTest, ShillPropertyHandlerServicePropertyChanged) {
EXPECT_EQ(1, listener_->initial_property_updates(
shill::kServiceCompleteListProperty)[kTestServicePath]);
// Change a property.
- base::FundamentalValue scan_interval(3);
+ base::Value scan_interval(3);
DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
dbus::ObjectPath(kTestServicePath),
shill::kScanIntervalProperty,
@@ -398,10 +398,9 @@ TEST_F(ShillPropertyHandlerTest, ShillPropertyHandlerServicePropertyChanged) {
// updates.
listener_->reset_list_updates();
DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
- dbus::ObjectPath(kTestServicePath),
- shill::kVisibleProperty,
- base::FundamentalValue(false),
- base::Bind(&base::DoNothing), base::Bind(&ErrorCallbackFunction));
+ dbus::ObjectPath(kTestServicePath), shill::kVisibleProperty,
+ base::Value(false), base::Bind(&base::DoNothing),
+ base::Bind(&ErrorCallbackFunction));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1, listener_->list_updates(shill::kServiceCompleteListProperty));
@@ -433,7 +432,7 @@ TEST_F(ShillPropertyHandlerTest, ShillPropertyHandlerIPConfigPropertyChanged) {
dbus::ObjectPath(kTestIPConfigPath),
shill::kNameServersProperty, dns_servers,
base::Bind(&DoNothingWithCallStatus));
- base::FundamentalValue prefixlen(8);
+ base::Value prefixlen(8);
DBusThreadManager::Get()->GetShillIPConfigClient()->SetProperty(
dbus::ObjectPath(kTestIPConfigPath),
shill::kPrefixlenProperty, prefixlen,
« no previous file with comments | « chromeos/network/shill_property_handler.cc ('k') | components/arc/bluetooth/bluetooth_type_converters_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698