Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chromeos/network/network_connect_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_service_client_unittest.cc ('k') | chromeos/network/network_device_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_connect_unittest.cc
diff --git a/chromeos/network/network_connect_unittest.cc b/chromeos/network/network_connect_unittest.cc
index aaafc63efcb88209ff89b15447b966cac22def7e..d39a93215b21e4c857042c5732662b4d74045603 100644
--- a/chromeos/network/network_connect_unittest.cc
+++ b/chromeos/network/network_connect_unittest.cc
@@ -122,9 +122,8 @@ class NetworkConnectTest : public testing::Test {
service_test_->SetServiceProperty(kWiFi1ServicePath,
shill::kSecurityClassProperty,
base::StringValue(shill::kSecurityWep));
- service_test_->SetServiceProperty(kWiFi1ServicePath,
- shill::kConnectableProperty,
- base::FundamentalValue(true));
+ service_test_->SetServiceProperty(
+ kWiFi1ServicePath, shill::kConnectableProperty, base::Value(true));
service_test_->SetServiceProperty(kWiFi1ServicePath,
shill::kPassphraseProperty,
base::StringValue("password"));
@@ -133,15 +132,14 @@ class NetworkConnectTest : public testing::Test {
service_test_->AddService(kCellular1ServicePath, kCellular1Guid,
"cellular1", shill::kTypeCellular,
shill::kStateIdle, add_to_visible);
- service_test_->SetServiceProperty(kCellular1ServicePath,
- shill::kConnectableProperty,
- base::FundamentalValue(true));
+ service_test_->SetServiceProperty(
+ kCellular1ServicePath, shill::kConnectableProperty, base::Value(true));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kActivationStateProperty,
base::StringValue(shill::kActivationStateActivated));
service_test_->SetServiceProperty(kCellular1ServicePath,
shill::kOutOfCreditsProperty,
- base::FundamentalValue(false));
+ base::Value(false));
base::RunLoop().RunUntilIdle();
}
@@ -238,9 +236,8 @@ TEST_F(NetworkConnectTest, ShowNetworkSettings_CellOutOfCredits) {
EXPECT_CALL(*mock_delegate_, ShowNetworkSettings(kCellular1Guid)).Times(0);
EXPECT_CALL(*mock_delegate_, ShowMobileSetupDialog(kCellular1Guid));
- service_test_->SetServiceProperty(kCellular1ServicePath,
- shill::kOutOfCreditsProperty,
- base::FundamentalValue(true));
+ service_test_->SetServiceProperty(
+ kCellular1ServicePath, shill::kOutOfCreditsProperty, base::Value(true));
base::RunLoop().RunUntilIdle();
NetworkConnect::Get()->MaybeShowConfigureUI(
@@ -278,9 +275,8 @@ TEST_F(NetworkConnectTest, ShowMobileSimDialog) {
NetworkConnect::Get()->SetTechnologyEnabled(NetworkTypePattern::Cellular(),
false);
- device_test_->SetDeviceProperty(kCellular1DevicePath,
- shill::kSIMPresentProperty,
- base::FundamentalValue(true));
+ device_test_->SetDeviceProperty(
+ kCellular1DevicePath, shill::kSIMPresentProperty, base::Value(true));
device_test_->SetSimLocked(kCellular1DevicePath, true);
base::RunLoop().RunUntilIdle();
@@ -295,9 +291,8 @@ TEST_F(NetworkConnectTest, ShowMobileSimDialog_SimAbsent) {
NetworkConnect::Get()->SetTechnologyEnabled(NetworkTypePattern::Cellular(),
false);
- device_test_->SetDeviceProperty(kCellular1DevicePath,
- shill::kSIMPresentProperty,
- base::FundamentalValue(false));
+ device_test_->SetDeviceProperty(
+ kCellular1DevicePath, shill::kSIMPresentProperty, base::Value(false));
device_test_->SetSimLocked(kCellular1DevicePath, true);
base::RunLoop().RunUntilIdle();
@@ -312,9 +307,8 @@ TEST_F(NetworkConnectTest, ShowMobileSimDialog_SimUnlocked) {
NetworkConnect::Get()->SetTechnologyEnabled(NetworkTypePattern::Cellular(),
false);
- device_test_->SetDeviceProperty(kCellular1DevicePath,
- shill::kSIMPresentProperty,
- base::FundamentalValue(true));
+ device_test_->SetDeviceProperty(
+ kCellular1DevicePath, shill::kSIMPresentProperty, base::Value(true));
device_test_->SetSimLocked(kCellular1DevicePath, false);
base::RunLoop().RunUntilIdle();
« no previous file with comments | « chromeos/dbus/shill_service_client_unittest.cc ('k') | chromeos/network/network_device_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698