Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chromeos/dbus/shill_ipconfig_client_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_ipconfig_client_unittest.cc
diff --git a/chromeos/dbus/shill_ipconfig_client_unittest.cc b/chromeos/dbus/shill_ipconfig_client_unittest.cc
index c559f965ee677627b683e6eebae7b07e8abde02d..8f884d7a5c9084856754ad254cbe048036ce189d 100644
--- a/chromeos/dbus/shill_ipconfig_client_unittest.cc
+++ b/chromeos/dbus/shill_ipconfig_client_unittest.cc
@@ -50,7 +50,7 @@ class ShillIPConfigClientTest : public ShillClientUnittestBase {
TEST_F(ShillIPConfigClientTest, PropertyChanged) {
// Create a signal.
- const base::FundamentalValue kConnected(true);
+ const base::Value kConnected(true);
dbus::Signal signal(shill::kFlimflamIPConfigInterface,
shill::kMonitorPropertyChanged);
dbus::MessageWriter writer(&signal);
@@ -107,8 +107,7 @@ TEST_F(ShillIPConfigClientTest, GetProperties) {
base::DictionaryValue value;
value.SetWithoutPathExpansion(shill::kAddressProperty,
new base::StringValue(kAddress));
- value.SetWithoutPathExpansion(shill::kMtuProperty,
- new base::FundamentalValue(kMtu));
+ value.SetWithoutPathExpansion(shill::kMtuProperty, new base::Value(kMtu));
// Set expectations.
PrepareForMethodCall(shill::kGetPropertiesFunction,
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698