Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index 5675e4ab08bf33ebcaa76791f3b66ebbed61b0ac..528603c73fb0ce3fb2a6a0115141bd050851a9b3 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -154,7 +154,7 @@ Status CheckSessionCreated(Session* session) {
return Status(kSessionNotCreatedException, status);
base::ListValue args;
- std::unique_ptr<base::Value> result(new base::FundamentalValue(0));
+ std::unique_ptr<base::Value> result(new base::Value(0));
status = web_view->CallFunction(session->GetCurrentFrameId(),
"function(s) { return 1; }", args, &result);
if (status.IsError())
@@ -509,7 +509,7 @@ Status ExecuteIsLoading(Session* session,
session->GetCurrentFrameId(), nullptr, &is_pending);
if (status.IsError())
return status;
- value->reset(new base::FundamentalValue(is_pending));
+ value->reset(new base::Value(is_pending));
return Status(kOk);
}
@@ -544,7 +544,7 @@ Status ExecuteGetNetworkConnection(Session* session,
int connection_type = 0;
connection_type = desktop->GetNetworkConnection();
- value->reset(new base::FundamentalValue(connection_type));
+ value->reset(new base::Value(connection_type));
return Status(kOk);
}
@@ -637,7 +637,7 @@ Status ExecuteSetNetworkConnection(Session* session,
*session->overridden_network_conditions);
}
- value->reset(new base::FundamentalValue(connection_type));
+ value->reset(new base::Value(connection_type));
return Status(kOk);
}
@@ -829,7 +829,7 @@ Status ExecuteUploadFile(Session* session,
Status ExecuteIsAutoReporting(Session* session,
const base::DictionaryValue& params,
std::unique_ptr<base::Value>* value) {
- value->reset(new base::FundamentalValue(session->auto_reporting_enabled));
+ value->reset(new base::Value(session->auto_reporting_enabled));
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/server/http_handler_unittest.cc ('k') | chromecast/base/device_capabilities_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698