Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index dc5c9cd5fc588d2ef93349f40e8226b19d453398..8c9774498ddf1e21ae3324347f1cb877b6f271fa 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -92,8 +92,7 @@ TEST_F(ManifestUnitTest, Extension) {
// Set the manifest_version to 2; background_page should stop working.
value.clear();
- MutateManifest(
- &manifest, keys::kManifestVersion, new base::FundamentalValue(2));
+ MutateManifest(&manifest, keys::kManifestVersion, new base::Value(2));
EXPECT_FALSE(manifest->GetString("background_page", &value));
EXPECT_EQ("", value);
@@ -197,8 +196,7 @@ TEST_F(ManifestUnitTest, RestrictedKeys) {
EXPECT_FALSE(manifest->HasKey(keys::kCommands));
EXPECT_FALSE(manifest->Get(keys::kCommands, &output));
- MutateManifest(
- &manifest, keys::kManifestVersion, new base::FundamentalValue(2));
+ MutateManifest(&manifest, keys::kManifestVersion, new base::Value(2));
EXPECT_TRUE(manifest->HasKey(keys::kCommands));
EXPECT_TRUE(manifest->Get(keys::kCommands, &output));
« no previous file with comments | « chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc ('k') | chrome/service/service_process_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698