Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
index bc45d9e6cf2f69591bcf653a00e1ebbc839e01ba..43bb3f9b8b5b36c9c7f389f8d208ec64eba7bd76 100644
--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
@@ -87,18 +87,18 @@ void TranslateInternalsHandler::Observe(
}
base::DictionaryValue dict;
- dict.Set("time", new base::FundamentalValue(
- language_detection_details->time.ToJsTime()));
+ dict.Set("time",
+ new base::Value(language_detection_details->time.ToJsTime()));
dict.Set("url",
new base::StringValue(language_detection_details->url.spec()));
dict.Set("content_language",
new base::StringValue(language_detection_details->content_language));
dict.Set("cld_language",
new base::StringValue(language_detection_details->cld_language));
- dict.Set("is_cld_reliable", new base::FundamentalValue(
- language_detection_details->is_cld_reliable));
- dict.Set("has_notranslate", new base::FundamentalValue(
- language_detection_details->has_notranslate));
+ dict.Set("is_cld_reliable",
+ new base::Value(language_detection_details->is_cld_reliable));
+ dict.Set("has_notranslate",
+ new base::Value(language_detection_details->has_notranslate));
dict.Set(
"html_root_language",
new base::StringValue(language_detection_details->html_root_language));
@@ -112,18 +112,18 @@ void TranslateInternalsHandler::Observe(
void TranslateInternalsHandler::OnTranslateError(
const translate::TranslateErrorDetails& details) {
base::DictionaryValue dict;
- dict.Set("time", new base::FundamentalValue(details.time.ToJsTime()));
+ dict.Set("time", new base::Value(details.time.ToJsTime()));
dict.Set("url", new base::StringValue(details.url.spec()));
- dict.Set("error", new base::FundamentalValue(details.error));
+ dict.Set("error", new base::Value(details.error));
SendMessageToJs("translateErrorDetailsAdded", dict);
}
void TranslateInternalsHandler::OnTranslateEvent(
const translate::TranslateEventDetails& details) {
base::DictionaryValue dict;
- dict.Set("time", new base::FundamentalValue(details.time.ToJsTime()));
+ dict.Set("time", new base::Value(details.time.ToJsTime()));
dict.Set("filename", new base::StringValue(details.filename));
- dict.Set("line", new base::FundamentalValue(details.line));
+ dict.Set("line", new base::Value(details.line));
dict.Set("message", new base::StringValue(details.message));
SendMessageToJs("translateEventDetailsAdded", dict);
}
@@ -239,7 +239,7 @@ void TranslateInternalsHandler::SendSupportedLanguagesToJs() {
dict.Set("languages", languages_list);
dict.Set("alpha_languages", alpha_languages_list);
- dict.Set("last_updated", new base::FundamentalValue(last_updated.ToJsTime()));
+ dict.Set("last_updated", new base::Value(last_updated.ToJsTime()));
SendMessageToJs("supportedLanguagesUpdated", dict);
}
@@ -253,7 +253,7 @@ void TranslateInternalsHandler::SendCountryToJs(bool was_updated) {
base::DictionaryValue dict;
if (!country.empty()) {
dict.Set("country", new base::StringValue(country));
- dict.Set("update", new base::FundamentalValue(was_updated));
+ dict.Set("update", new base::Value(was_updated));
}
SendMessageToJs("countryUpdated", dict);
}
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui_unittest.cc ('k') | chrome/browser/ui/webui/welcome_win10_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698