Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc b/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
index 7d129887eeacc95fd805d853eec886ea2ed31a98..2452adb6c79e9babc94767d5ff06b96b8a57ebde 100644
--- a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
@@ -51,7 +51,7 @@ class MetricsReportingHandlerTest : public testing::Test {
EXPECT_TRUE(test_web_ui()->call_data().empty());
base::ListValue args;
- args.Append(base::MakeUnique<base::FundamentalValue>(1));
+ args.Append(base::MakeUnique<base::Value>(1));
handler()->HandleGetMetricsReporting(&args);
EXPECT_TRUE(handler()->IsJavascriptAllowed());
@@ -106,8 +106,8 @@ TEST_F(MetricsReportingHandlerTest, PolicyChangesNotifyPage) {
// Change the policy, check that the page was notified.
map()->Set(policy::key::kMetricsReportingEnabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
- policy::POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::FundamentalValue>(true), nullptr);
+ policy::POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(true),
+ nullptr);
provider()->UpdateChromePolicy(*map());
EXPECT_EQ(1u, test_web_ui()->call_data().size());
@@ -117,8 +117,8 @@ TEST_F(MetricsReportingHandlerTest, PolicyChangesNotifyPage) {
// Policies changing while JavaScript is disabled shouldn't notify the page.
map()->Set(policy::key::kMetricsReportingEnabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
- policy::POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::FundamentalValue>(false), nullptr);
+ policy::POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(false),
+ nullptr);
provider()->UpdateChromePolicy(*map());
EXPECT_TRUE(test_web_ui()->call_data().empty());
}
« no previous file with comments | « chrome/browser/ui/webui/settings/font_handler.cc ('k') | chrome/browser/ui/webui/settings/profile_info_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698