chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/certificates_handler.cc ('k') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

index 36a33031d53da16f506e6a93ec4467ce50e392b8..1f736388583226ba01fab56547ada9404b550a7b 100644

--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

@@ -248,7 +248,7 @@ void ChangePictureHandler::SendSelectedImage() {

void ChangePictureHandler::SendProfileImage(const gfx::ImageSkia& image,

bool should_select) {

base::StringValue data_url(webui::GetBitmapDataUrl(*image.bitmap()));

- base::FundamentalValue select(should_select);

+ base::Value select(should_select);

CallJavascriptFunction("cr.webUIListenerCallback",

base::StringValue("profile-image-changed"), data_url,

select);

@@ -369,7 +369,7 @@ void ChangePictureHandler::SetImageFromCamera(const gfx::ImageSkia& photo) {

void ChangePictureHandler::SetCameraPresent(bool present) {

CallJavascriptFunction("cr.webUIListenerCallback",

base::StringValue("camera-presence-changed"),

- base::FundamentalValue(present));

+ base::Value(present));

}

void ChangePictureHandler::OnCameraPresenceCheckDone(bool is_camera_present) {